MS-930 Implement stateful face matcher that reduces amount of allocations#1151
Merged
Merged
Conversation
BurningAXE
reviewed
Mar 25, 2025
8e88e4b to
d2aefc6
Compare
BurningAXE
reviewed
Mar 25, 2025
BurningAXE
reviewed
Mar 25, 2025
BurningAXE
reviewed
Mar 25, 2025
BurningAXE
requested changes
Mar 25, 2025
d2aefc6 to
fdcffc2
Compare
|
BurningAXE
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



JIRA ticket
Will be released in: 2025.2.0
This is an experimental implementation of the suggestion in the JIRA ticket, it could be polished to be production-ready if required.
Notable changes
Surprisingly the change is way less noticeable in my very basic benchmarking (running identification on 50k candidates using ROCv3 on a Lenovo Tab 8):
As part of this task, I also investigated the feasibility of the same refactoring for fingerprints and decided against it for the following reasons:
Additional work checklist