[MS-961] Remove templateQualityScore from FingerprintSample #1154
Merged
Conversation
meladRaouf
force-pushed
the
feature/MS-961-upadte-realm-db
branch
from
332d5bb to
dfd6119
Compare
meladRaouf
force-pushed
the
feature/MS-961-upadte-realm-db
branch
from
dfd6119 to
5716be3
Compare
|
meladRaouf
requested review from
BurningAXE,
alex-vt,
alexandr-simprints and
luhmirin-s
luhmirin-s
approved these changes
Apr 7, 2025
BurningAXE
reviewed
Apr 7, 2025
|
|
||
| @Keep | ||
| internal data class ApiFingerprintTemplate( | ||
| val quality: Int, |
Contributor
There was a problem hiding this comment.
Don't we need to send the template quality to BFSID?
Collaborator
Author
There was a problem hiding this comment.
we send it as part of the FingerprintCaptureEvent payload
it is sent as part of the session in json format
quality is still exist in ApiFingerprintCapturePayload
BurningAXE
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket
Will be released in: 2025.2.0
Based on the Slack discussion, the
templateQualityScorefield is unnecessary and does not need to be stored in the records database.