Skip to content

MS-969 Another stab at edge-to-edge support#1162

Merged
meladRaouf merged 3 commits into
mainfrom
feature/MS-969-edge-to-edge-support
Apr 16, 2025
Merged

MS-969 Another stab at edge-to-edge support#1162
meladRaouf merged 3 commits into
mainfrom
feature/MS-969-edge-to-edge-support

Conversation

@luhmirin-s
Copy link
Copy Markdown
Contributor

JIRA ticket
Will be released in: 2025.2.0

Root cause analysis (for bugfixes only)

The first known affected version: 2025.1.0 and likely older ones.

  • In Android 15 edge-to-edge is enabled by default. During the initial exploration, it all seemed to work as expected, something changed under the hood and on the Android 15 device the status bar padding is all over the place.
  • Some screens had the white line under the status bar others had content under the status bar.
  • Same random handling applied to the bottom bar.

Notable changes

  • Added a utility function that finds the system bar insets via compat library and applies inset values as top and bottom padding in the screen.
  • Some screens have AppBarLayout, to avoid weird shadows at the top border of the bar, the top padding is applied to the AppBarLayout itself, effectively pushing it under the system bar.

Testing guidance

  • Compile and install the branch.
  • Start the dual modality enrollment flow, log in and capture fingerprints and the face.
  • Bonus points to intentionally disable BT and unpair Vero to check as many of the connection flow screens as possible as well.
  • Click through all screens in the dashboard.
  • Start another flow and reject it to check exit form.

Additional work checklist

  • Effect on other features and security has been considered
  • Design document marked as "In development" (if applicable)
  • External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
  • Test cases in Testiny are up to date (or ticket created)
  • Other teams notified about the changes (if applicable)

@luhmirin-s luhmirin-s requested review from a team, BurningAXE, TristramN, alex-vt, alexandr-simprints, meladRaouf and ybourgery and removed request for a team April 10, 2025 12:09
@cla-bot cla-bot Bot added the ... label Apr 10, 2025
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 10, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@luhmirin-s
Copy link
Copy Markdown
Contributor Author

This PR is exclusively UI code, so the coverage will never be green.

@alexandr-simprints
Copy link
Copy Markdown
Contributor

Tested, works as expected

@meladRaouf meladRaouf merged commit fcfc471 into main Apr 16, 2025
10 of 12 checks passed
@meladRaouf meladRaouf deleted the feature/MS-969-edge-to-edge-support branch April 16, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants