[MS-120] Skipping non-existent privacy notice download 404 logging#1179
Merged
Conversation
alex-vt
requested review from
BurningAXE,
alexandr-simprints,
luhmirin-s and
meladRaouf
luhmirin-s
reviewed
May 6, 2025
| companion object { | ||
| @VisibleForTesting | ||
| const val PRIVACY_NOTICE_FILE = "privacy_notice" | ||
| private const val NOT_FOUND_STATUS_CODE = 404 |
Contributor
There was a problem hiding this comment.
I would suggest using the codes defined in the HTTP library to skip on re-defining them in our code base.
luhmirin-s
approved these changes
May 6, 2025
luhmirin-s
approved these changes
May 6, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket
Will be released in: 2025.2.0
Notable changes
Not user-facing, only affects logging:
When an API call for downloading a privacy notice occurs, and returns 404 (not found) - not logging this.