[MS-1007] Log an exception when subjectActions are null

[BurningAXE]

JIRA ticket
Will be released in: 2025.2.0

Notable changes

• Added a logged exception in case subjectActions are null when they shouldn't

Testing guidance

• Describe how the reviewers can verify that issue is fixed

Additional work checklist

• Effect on other features and security has been considered
• Design document marked as "In development" (if applicable)
• External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
• Test cases in Testiny are up to date (or ticket created)
• Other teams notified about the changes (if applicable)

[luhmirin-s]

Do the CoPilot on this, out of curiosity :D

[Copilot]

Pull Request Overview

Adds explicit error logging and null handling for missing enrolment records in the GetEnrolmentCreationEventForSubjectUseCase.

• Introduces a Simber.e log when recordCreationEvent is null
• Replaces the Elvis operator with an explicit if/else to return null on failure

Comments suppressed due to low confidence (2)

feature/client-api/src/main/java/com/simprints/feature/clientapi/usecases/GetEnrolmentCreationEventForSubjectUseCase.kt:42

• [nitpick] The log message references 'subjectActions', which isn't defined in this context. Consider clarifying it to something like "Couldn't find enrolment creation event for subjectId: $subjectId" to avoid confusion.

Simber.e("Couldn't find enrolment for subjectActions", IllegalStateException("No enrolment record found for subjectId: $subjectId"))

feature/client-api/src/main/java/com/simprints/feature/clientapi/usecases/GetEnrolmentCreationEventForSubjectUseCase.kt:41

• The new null branch with logging isn't covered by existing tests. Add a test to verify that an exception is logged when no enrolment record is found for a subject.

if (recordCreationEvent == null) {

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud