MS-989 SimFace in dev builds only#1203
Merged
Merged
Conversation
luhmirin-s
changed the title
luhmirin-s
changed the title
luhmirin-s
requested review from
a team,
BurningAXE,
TristramN,
alex-vt,
alexandr-simprints,
meladRaouf and
ybourgery
and removed request for
a team
BurningAXE
reviewed
May 29, 2025
| if (version == rocV3BioSdk.version) rocV3BioSdk else rocV1BioSdk | ||
| } | ||
| FaceConfiguration.BioSdk.SIM_FACE -> resolveSimFaceVersionUseCase() | ||
| FaceConfiguration.BioSdk.RANK_ONE -> resolveRankOneVersionUseCase() |
Contributor
There was a problem hiding this comment.
It's a matter of preference but do we really need to extract something as simple as the version resolving? It seems the overhead is higher than the code itself.
Contributor
Author
There was a problem hiding this comment.
It is not necessary, but it has the benefit of isolating each SDK's logic.
Honestly, I was just trying a lot of things to minimise the amount of classes that we would need to duplicate per build type and this is a by-product of the experimentation. We can simplify it when the need for build types is gone.
BurningAXE
approved these changes
May 29, 2025
Contributor
BurningAXE
left a comment
BurningAXE
left a comment
There was a problem hiding this comment.
Awesome that we won't inflate release size needlessly!
alex-vt
approved these changes
Jun 3, 2025
luhmirin-s
force-pushed
the
feature/MS-988-simface-integration
branch
from
974b4a4 to
6167762
Compare
luhmirin-s
force-pushed
the
feature/MS-989-simface-in-dev-only
branch
from
7b69efe to
fa6a305
Compare
luhmirin-s
force-pushed
the
feature/MS-988-simface-integration
branch
from
6167762 to
76fc303
Compare
luhmirin-s
force-pushed
the
feature/MS-989-simface-in-dev-only
branch
from
fa6a305 to
ae4e39e
Compare
luhmirin-s
force-pushed
the
feature/MS-988-simface-integration
branch
from
76fc303 to
7f07880
Compare
meladRaouf
approved these changes
Jun 3, 2025
luhmirin-s
force-pushed
the
feature/MS-988-simface-integration
branch
from
7f07880 to
be324d3
Compare
luhmirin-s
force-pushed
the
feature/MS-989-simface-in-dev-only
branch
from
ae4e39e to
659fe32
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket
Will be released in: 2025.2.0
Notable changes
simFacefield in the config should only be provided to dev projects by the backend, so there is little to no risk of it affecting the release build. The code itself does not add any noticeable difference in the APK file.APK breakdown
Both APKs were generated from the same code/commit:
Testing guidance
Additional work checklist