Skip to content

MS-122 Secure prefs everywhere#1221

Merged
luhmirin-s merged 3 commits into
mainfrom
feature/MS-122-secure-prefs-everywhere
Jul 1, 2025
Merged

MS-122 Secure prefs everywhere#1221
luhmirin-s merged 3 commits into
mainfrom
feature/MS-122-secure-prefs-everywhere

Conversation

@luhmirin-s
Copy link
Copy Markdown
Contributor

JIRA ticket
Will be released in: 2025.3.0

Notable changes

  • Moving a couple of remaining cases of shared prefs usage to the encrypted counterpart to avoid accidentally leaking some IDs/domain. The risk was always very low, but this ticket has been in the backlog for too long by now.
  • Did not move the language helper since it is fine as-is (it stores only the language code), and the performance penalty from encryption might affect app startup times.

Testing guidance

  • Use the app as usual - upsync progress should be reported correctly.

Additional work checklist

  • Effect on other features and security has been considered
  • Design document marked as "In development" (if applicable)
  • External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
  • Test cases in Testiny are up to date (or ticket created)
  • Other teams notified about the changes (if applicable)

@cla-bot cla-bot Bot added the ... label Jun 12, 2025
@luhmirin-s luhmirin-s requested review from a team, BurningAXE, TristramN, alex-vt, alexandr-simprints, meladRaouf and ybourgery and removed request for a team June 12, 2025 12:04
@luhmirin-s luhmirin-s force-pushed the feature/MS-122-secure-prefs-everywhere branch from 40753db to d200b2c Compare June 17, 2025 07:12
@luhmirin-s luhmirin-s force-pushed the feature/MS-122-secure-prefs-everywhere branch from d200b2c to 3a86d36 Compare June 26, 2025 07:33
@sonarqubecloud
Copy link
Copy Markdown

@luhmirin-s luhmirin-s merged commit 0e14bce into main Jul 1, 2025
12 checks passed
@luhmirin-s luhmirin-s deleted the feature/MS-122-secure-prefs-everywhere branch July 1, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants