[MS-1028] Fix pagination logic by adjusting pageSize calculation in RoomEnrolmentRecordLocalDataSource#1226
Merged
Conversation
…oomEnrolmentRecordLocalDataSource
|
luhmirin-s
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



JIRA ticket
Will be released in: 2025.2.0
Root cause analysis (for bugfixes only)
First known affected version: not yet released
Current logic calculates pageSize = range.last - range.first, which skips the last item in the range when range.last == range.first + pageSize.
Update to:
pageSize = range.last - range.first + 1
to include the full range.
Testing guidance
Normal identification shows that the number of identified subjects in each range is off by one, typically one less than expected.
Additional work checklist