Skip to content

[MS-1028] Fix pagination logic by adjusting pageSize calculation in RoomEnrolmentRecordLocalDataSource#1226

Merged
meladRaouf merged 1 commit into
release/2025.2.0-draftfrom
bugfix/range-issue
Jun 16, 2025
Merged

[MS-1028] Fix pagination logic by adjusting pageSize calculation in RoomEnrolmentRecordLocalDataSource#1226
meladRaouf merged 1 commit into
release/2025.2.0-draftfrom
bugfix/range-issue

Conversation

@meladRaouf
Copy link
Copy Markdown
Collaborator

JIRA ticket
Will be released in: 2025.2.0

Root cause analysis (for bugfixes only)

First known affected version: not yet released

Current logic calculates pageSize = range.last - range.first, which skips the last item in the range when range.last == range.first + pageSize.
Update to:
pageSize = range.last - range.first + 1
to include the full range.

Testing guidance

Normal identification shows that the number of identified subjects in each range is off by one, typically one less than expected.

Additional work checklist

  • Effect on other features and security has been considered
  • Design document marked as "In development" (if applicable)
  • External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
  • Test cases in Testiny are up to date (or ticket created)
  • Other teams notified about the changes (if applicable)

@cla-bot cla-bot Bot added the ... label Jun 16, 2025
@meladRaouf meladRaouf changed the base branch from main to release/2025.2.0-draft June 16, 2025 08:22
@meladRaouf meladRaouf requested review from a team, BurningAXE, TristramN, alex-vt, alexandr-simprints, luhmirin-s and ybourgery and removed request for a team June 16, 2025 08:22
@sonarqubecloud
Copy link
Copy Markdown

@meladRaouf meladRaouf merged commit fad8844 into release/2025.2.0-draft Jun 16, 2025
20 of 21 checks passed
@meladRaouf meladRaouf deleted the bugfix/range-issue branch June 16, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants