[MS-1044] CoSync Background Syncing - Phase 1 (MVP)#1247
Merged
Conversation
BurningAXE
force-pushed
the
MS-1044-co-down-sync
branch
from
dd127ea to
6900f70
Compare
BurningAXE
force-pushed
the
MS-1044-co-down-sync
branch
10 times, most recently
from
e3522eb to
25c9d22
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements the first phase (MVP) of CoSync background syncing by adding support for CommCare as an alternative sync source alongside the existing Simprints backend integration. The key changes include refactoring the sync infrastructure to support multiple sync providers, implementing CommCare content provider integration, and introducing proper permission handling for CommCare access.
Key changes:
- Refactored sync architecture to support multiple providers (Simprints and CommCare)
- Implemented CommCare content provider integration for syncing data
- Added permission handling for CommCare access in setup flow
Reviewed Changes
Copilot reviewed 93 out of 93 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| infra/sync/src/main/java/com/simprints/infra/sync/config/usecase/ResetLocalRecordsIfConfigChangedUseCase.kt | Enhanced to detect sync source changes between Simprints and CommCare |
| infra/event-sync/src/main/java/com/simprints/infra/eventsync/sync/master/EventSyncMasterWorker.kt | Updated master worker to support both Simprints and CommCare sync workflows |
| infra/event-sync/src/main/java/com/simprints/infra/eventsync/sync/down/workers/ | Created base worker class and specialized implementations for Simprints and CommCare |
| infra/event-sync/src/main/java/com/simprints/infra/eventsync/event/commcare/CommCareEventDataSource.kt | New CommCare content provider integration for data fetching |
| infra/config-store/src/main/proto/project_config.proto | Extended configuration to support CommCare sync configuration |
| feature/setup/src/main/java/com/simprints/feature/setup/screen/ | Enhanced setup flow to request CommCare permissions when needed |
| infra/resources/src/main/res/values/strings.xml | Added CommCare-specific UI strings and renamed generic strings |
BurningAXE
force-pushed
the
MS-1044-co-down-sync
branch
from
25c9d22 to
38ad617
Compare
BurningAXE
requested review from
a team,
TristramN,
alex-vt,
alexandr-simprints,
luhmirin-s,
meladRaouf and
ybourgery
and removed request for
a team
luhmirin-s
reviewed
Jul 31, 2025
Contributor
luhmirin-s
left a comment
luhmirin-s
left a comment
There was a problem hiding this comment.
All things considered, LGTM.
Left a couple of nitpicks, suggestions and questions that I would prefer to resolve before approving.
BurningAXE
force-pushed
the
MS-1044-co-down-sync
branch
2 times, most recently
from
ffbfeff to
b065cea
Compare
luhmirin-s
approved these changes
Aug 4, 2025
meladRaouf
approved these changes
Aug 6, 2025
alexandr-simprints
approved these changes
Aug 12, 2025
BurningAXE
force-pushed
the
MS-1044-co-down-sync
branch
from
b065cea to
20d2704
Compare
…ions and content provider URIs
BurningAXE
force-pushed
the
MS-1044-co-down-sync
branch
2 times, most recently
from
0312c4d to
e529332
Compare
…mmCare and make both down.CommCare and down.Simprints optional
BurningAXE
force-pushed
the
MS-1044-co-down-sync
branch
from
e529332 to
30057b8
Compare
BurningAXE
force-pushed
the
MS-1044-co-down-sync
branch
from
802dc12 to
ee7ae0d
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket
Will be released in: 2025.3.0
Notable changes
This is the first phase of CoDownSync - sort of an MVP where background syncing from CommCare works but in a "dumb" way where all records are fetched every time. Optimizations to this process will happen in Phase 2.
See CoPilot's (surprisingly good) description of the PR changes below.
Testing guidance
Additional work checklist