MS-1058 Prep work for sample upload with signed urls

[luhmirin-s]

JIRA ticket
Will be released in: 2025.3.0

Notable changes

• This PR adds some secondary changes for future refactoring of the sample upload. The actual upload logic requires much more changes than was anticipated and therefore will be done in a separate PR.
  • Added configuration fields for future use in sample upload.
  • Added a new event and scope type for sample upload.
  • Added additional fields to upsync event.

Testing guidance

• Poke around and check that nothing is broken. And that configuration has migrated correctly after update/install.

Additional work checklist

• Effect on other features and security has been considered
• Design document marked as "In development" (if applicable)
• External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
• Test cases in Testiny are up to date (or ticket created)
• Other teams notified about the changes (if applicable)

[alexandr-simprints]

This is just a general comment

Don't you find such conditions difficult to read? While it is a relatively short notation, wouldn't it be better to write such conditions in more human-friendly format?

with (currentData) {
    val hasNoSamples = !synchronization.hasSamples()
    val batchSizeIsEmpty = synchronization.up.simprints.batchSizes
                  .let { it.eventUpSyncs == 0 || it.eventDownSyncs == 0 }
    return@with hasNoSamples || batchSizeIsEmpty
}

[alexandr-simprints]

Should move it to a constant field?

[luhmirin-s]

Sure, although this is a very old migration, and there is little difference.

[alexandr-simprints]

Maybe it's time to refactor it a bit

val shouldAdd = listOf(content.sessionCount, content.eventDownSyncCount, content.eventUpSyncCount, content.sampleUpSyncCount).any { it > 0 }
if (shouldAdd) { ... }

[luhmirin-s]

I will move the check to a method in the content class to shorten the access.

In general, for string/null check I would agree. Making a full list object to iterate over a couple of boolean flags just feels wrong, tho. :D

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud