MS-1077 Only return templates of the correct format for matching

[luhmirin-s]

JIRA ticket
Will be released in: 2025.2.0

Root cause analysis (for bugfixes only)

First known affected version: 2025.2.0

• When fetching candidates for matching, we are filtering for "subject where any sample matches format". Which is correct, when a record can only have samples of the same format.
• With the capability to update records, there is a case when a record has samples of multiple formats for the same modality (e.g. updating templates from ROC v1 to v3).
• Attempting to match v1 template against v3 crashes ROC SDK.

Notable changes

• Add filtering to return only the templates in the requested format.
• Luckily, this does not affect the Room version of record storage.

Testing guidance

• Make a couple of records with ROC v1. Ask Yoann to update the record with v3 template. Run identification.

Additional work checklist

• Effect on other features and security has been considered
• Design document marked as "In development" (if applicable)
• External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
• Test cases in Testiny are up to date (or ticket created)
• Other teams notified about the changes (if applicable)

Note: Creating the PR while I am working on the unit tests to speed the process up a bit, since the setup to test the Realm data source is convoluted and might take a while.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[meladRaouf]

@luhmirin-s It might be helpful to include a test in RealmEnrolmentRecordLocalDataSourceTest as well.

[luhmirin-s]

@meladRaouf I agree, but the methods in question do not seem to be testable without significant refactoring. The existing tests for the method appear not to be testing anything. Lets push for the removal of realm instead :D