Skip to content

MS-1070 Persistent step cache fix#1274

Merged
luhmirin-s merged 3 commits into
mainfrom
feature/MS-1070-persistant-step-cache-fix
Jul 23, 2025
Merged

MS-1070 Persistent step cache fix#1274
luhmirin-s merged 3 commits into
mainfrom
feature/MS-1070-persistant-step-cache-fix

Conversation

@luhmirin-s
Copy link
Copy Markdown
Contributor

@luhmirin-s luhmirin-s commented Jul 21, 2025

JIRA ticket
Will be released in: 2025.3.0

Root cause analysis (for bugfixes only)

First known affected version: 2025.1.0

  • The issue is with the persistent orchestration cache - the change in settings/permissions triggers full recreation of OrchestrationActivity from the persistent store. And when unmarshalling step params (that are kept as Bundles), the custom parcelable parameters in those bundles lose the type information and are restored as generic maps.

Notable changes

  • Replace step parameters bundle with custom serialisable definition.
  • Introduces separate marker interfaces for step params and results to enable serialisation to work.
  • Once the cache issue was fixed, another related issue surfaced - when a step's fragment returns result after configuration change (nav graph recreation), the result handlers were not triggered.

Testing guidance

  • Run all orchestration flows in all possible combinations.

Additional work checklist

  • Effect on other features and security has been considered
  • Design document marked as "In development" (if applicable)
  • External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
  • Test cases in Testiny are up to date (or ticket created)
  • Other teams notified about the changes (if applicable)

@cla-bot cla-bot Bot added the ... label Jul 21, 2025
@luhmirin-s luhmirin-s force-pushed the feature/MS-1070-persistant-step-cache-fix branch from 2fb45b6 to 00957d3 Compare July 22, 2025 09:33
@luhmirin-s luhmirin-s marked this pull request as ready for review July 22, 2025 09:52
@luhmirin-s luhmirin-s requested review from a team, BurningAXE, TristramN, alex-vt, alexandr-simprints, meladRaouf and ybourgery and removed request for a team July 22, 2025 09:52
@luhmirin-s
Copy link
Copy Markdown
Contributor Author

luhmirin-s commented Jul 22, 2025

Uncovered code is either navigation contracts (basically just API definitions).

@luhmirin-s luhmirin-s changed the title MS-1070 Persistent step cache fix (WIP to run all tests in all modules) MS-1070 Persistent step cache fix Jul 22, 2025
@luhmirin-s luhmirin-s force-pushed the feature/MS-1070-persistant-step-cache-fix branch from 00957d3 to 39ef4c4 Compare July 22, 2025 13:08
@luhmirin-s luhmirin-s force-pushed the feature/MS-1070-persistant-step-cache-fix branch from 39ef4c4 to 3652b5f Compare July 23, 2025 07:44
@luhmirin-s luhmirin-s force-pushed the feature/MS-1070-persistant-step-cache-fix branch from 3652b5f to 5463513 Compare July 23, 2025 09:58
@luhmirin-s luhmirin-s merged commit 0fec8d5 into main Jul 23, 2025
11 of 13 checks passed
@luhmirin-s luhmirin-s deleted the feature/MS-1070-persistant-step-cache-fix branch July 23, 2025 10:12
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
63.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants