-
Notifications
You must be signed in to change notification settings - Fork 2
[MS-1076] Fix: SID is not handling the enrolment record events when there is the metadata field #1275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alexandr-simprints
merged 6 commits into
release/2025.2.0
from
MS-1076-sid-is-not-handling-the-enrolment-record-events-when-there-is-the-metadata-field
Jul 22, 2025
Merged
[MS-1076] Fix: SID is not handling the enrolment record events when there is the metadata field #1275
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d53317d
[MS-1065] Adding 'metadata' field to the ConfirmationCalloutEventV3ˆ
alexandr-simprints 2ccc58f
Merge remote-tracking branch 'origin/release/2025.2.0' into release/2…
alexandr-simprints c25fd06
[MS-1076] Changing metadata field from `HashMap` to a generic `Map` t…
alexandr-simprints 4c36e2b
[MS-1076] Adding descriptive comments for future reference
alexandr-simprints c76f49e
[MS-1076] Marking API data classes with @ExcludedFromGeneratedTestCov…
alexandr-simprints 0f98fea
[MS-1076] Marking domain model classes with @ExcludedFromGeneratedTes…
alexandr-simprints File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
...a/com/simprints/infra/enrolment/records/repository/remote/models/face/ApiFaceReference.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
...s/infra/enrolment/records/repository/remote/models/fingerprint/ApiFingerprintReference.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 8 additions & 1 deletion
9
...mprints/infra/eventsync/event/remote/models/subject/biometricref/face/ApiFaceReference.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,24 @@ | ||
| package com.simprints.infra.eventsync.event.remote.models.subject.biometricref.face | ||
|
|
||
| import androidx.annotation.Keep | ||
| import com.fasterxml.jackson.annotation.JsonTypeInfo | ||
| import com.simprints.core.ExcludedFromGeneratedTestCoverageReports | ||
| import com.simprints.infra.eventsync.event.remote.models.subject.biometricref.ApiBiometricReference | ||
| import com.simprints.infra.eventsync.event.remote.models.subject.biometricref.ApiBiometricReferenceType | ||
| import com.simprints.infra.eventsync.event.remote.models.subject.biometricref.ApiBiometricReferenceType.FaceReference | ||
| import java.util.UUID | ||
|
|
||
| @Keep | ||
| @ExcludedFromGeneratedTestCoverageReports("API model") | ||
| internal data class ApiFaceReference( | ||
| override val id: String = UUID.randomUUID().toString(), | ||
| val templates: List<ApiFaceTemplate>, | ||
| val format: String, | ||
| val metadata: HashMap<String, String>? = null, | ||
| // [MS-1076] The parent 'ApiBiometricReference' class should have its JsonSubTypes annotation updated to | ||
| // @JsonSubTypes.Type([...], looseHandling = true) once we update to SDK => 25 and Jackson => 2.16.0. | ||
| // Then, this annotation should be removed | ||
| @JsonTypeInfo(use = JsonTypeInfo.Id.NONE) | ||
| val metadata: Map<String, String>? = null, | ||
| ) : ApiBiometricReference { | ||
| override val type: ApiBiometricReferenceType = FaceReference | ||
| } |
9 changes: 8 additions & 1 deletion
9
...eventsync/event/remote/models/subject/biometricref/fingerprint/ApiFingerprintReference.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,24 @@ | ||
| package com.simprints.infra.eventsync.event.remote.models.subject.biometricref.fingerprint | ||
|
|
||
| import androidx.annotation.Keep | ||
| import com.fasterxml.jackson.annotation.JsonTypeInfo | ||
| import com.simprints.core.ExcludedFromGeneratedTestCoverageReports | ||
| import com.simprints.infra.eventsync.event.remote.models.subject.biometricref.ApiBiometricReference | ||
| import com.simprints.infra.eventsync.event.remote.models.subject.biometricref.ApiBiometricReferenceType | ||
| import com.simprints.infra.eventsync.event.remote.models.subject.biometricref.ApiBiometricReferenceType.FingerprintReference | ||
| import java.util.UUID | ||
|
|
||
| @Keep | ||
| @ExcludedFromGeneratedTestCoverageReports("API model") | ||
| internal data class ApiFingerprintReference( | ||
| override val id: String = UUID.randomUUID().toString(), | ||
| val templates: List<ApiFingerprintTemplate>, | ||
| val format: String, | ||
| val metadata: HashMap<String, String>? = null, | ||
| // [MS-1076] The parent 'ApiBiometricReference' class should have its JsonSubTypes annotation updated to | ||
| // @JsonSubTypes.Type([...], looseHandling = true) once we update to SDK => 25 and Jackson => 2.16.0. | ||
| // Then, this annotation should be removed | ||
| @JsonTypeInfo(use = JsonTypeInfo.Id.NONE) | ||
| val metadata: Map<String, String>? = null, | ||
| ) : ApiBiometricReference { | ||
| override val type: ApiBiometricReferenceType = FingerprintReference | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if :D