-
Notifications
You must be signed in to change notification settings - Fork 2
[MS-939] Sync UI/UX update #1282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
4bfc066
MS-939 Data layer preparation: data flow watchers
alex-vt bbe33d2
MS-939 Data layer preparation: EventSyncManager to allow default/cach…
alex-vt 4689cda
MS-939 Data layer preparation: EventSyncMasterWorker to allow disabli…
alex-vt 12c9f93
MS-939 Data layer preparation: sync progress callbacks needed for new…
alex-vt ced2db7
MS-939 Data layer preparation: project configuration extension functi…
alex-vt bef19b0
MS-939 Configurable container for XML layouts that will contain the n…
alex-vt 3964cfd
MS-939 Module list item view update for the new UI/UX
alex-vt 2bc38f0
MS-939 Kotlin Flow extension functions what will be used in the ViewM…
alex-vt 6707857
MS-939 Unified model for the UI state of the upcoming new sync UI/UX
alex-vt 094c05b
MS-939 New unified sync UI/UX in settings, dashboard and logout screen
alex-vt 8ebb4ee
MS-939 Cleanup of now unused old sync UI
alex-vt 3eb98d8
MS-939 Tests for ViewModel of the new unified sync UI/UX
alex-vt c39fe54
MS-939 Test name correction for EventSyncManager new UI/UX related ch…
alex-vt dbabaeb
MS-939 EventSyncMasterWorkerTest completed
alex-vt 50e387e
MS-939 Logout/MainSyncFragmentTest completed
alex-vt 76578d1
Merge branch 'main' into feature/sync-ui-ux-update
alex-vt 14797da
MS-939 Criteria fix for isModuleSelectionAvailable
alex-vt 5753b6b
MS-939 Stream observer function naming unified to observe
alex-vt c10299e
MS-939 countEventsToDownload cache timestamping fix
alex-vt acecdd3
MS-939 countEventsToDownload swapped tests fix
alex-vt de97425
MS-939 Layout: panel gap reduced; code cleanup
alex-vt 35f0425
MS-939 Module selection requirement dropped for pre-logout sync info
alex-vt 222a8d4
MS-939 Sync info fragment parts visibility control code cleanup
alex-vt 2dd3ac8
MS-939 Module selection requirement dropped for pre-logout sync info …
alex-vt 1132682
MS-939 Sync info placeholder code cleanup
alex-vt f7ce046
MS-939 SyncOrchestratorImpl associateWithIfSyncing explained in more …
alex-vt e2e470d
MS-939 FragmentContainerView for sync info named SyncFragmentContaine…
alex-vt 2f5464a
MS-939 Logout even made consumable after onResume
alex-vt b4c4b6e
MS-939 Timer extracted for TimeHelper
alex-vt 1d6c1a3
MS-939 Sync info observer calculation use case extracted from the vie…
alex-vt 470f54a
MS-939 Image sync button coloring moved to XML
alex-vt 2ed78a2
MS-939 Existing timestamp formatter reused
alex-vt f6f1793
MS-939 Image sync timestamp in millis instead of seconds
alex-vt 31610f9
MS-939 Down-sync event counter caching moved to the use case
alex-vt 8f26844
MS-939 View pulse animation helper extracted for general use
alex-vt 95ab6b1
Merge branch 'main' into feature/sync-ui-ux-update
alex-vt 57beaac
MS-939 Lint cleanup
alex-vt fbad0bd
MS-939 Test fix
alex-vt 8a43197
Merge branch 'main' into feature/sync-ui-ux-update
alex-vt 5ae3531
MS-939 CommCare changes integration step 1: post-merge cleanup
alex-vt 7f8ac19
MS-939 CommCare changes integration step 2: the missing functionality…
alex-vt 4c932fa
MS-939 CommCare changes integration step 2: CommCare permission check…
alex-vt bd779d6
MS-939 Image sync timestamp fix
alex-vt 6943433
Merge branch 'main' into feature/sync-ui-ux-update
alex-vt 6081d28
MS-939 Cleanup
alex-vt a76e2f3
MS-939 Sync button still enabled when CommCare permission is missing …
alex-vt 47803ae
MS-939 EventSyncVisibleSection explained in more detail as EventSyncV…
alex-vt a8d254b
MS-939 Sync button visibility logic update
alex-vt ae570e4
MS-939 Sync button visibility logic update tests cleanup
alex-vt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
101 changes: 0 additions & 101 deletions
101
feature/dashboard/src/main/java/com/simprints/feature/dashboard/main/sync/SyncFragment.kt
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I would recommend using
view.isVisible = true/falseandview.isInvisible = true/falseextensions to keep the code a bit cleaner.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The views have 3 states of visibility, and
isVisibleandisInvisibletoggle pairs of those is a less readable way than specifying the needed visibility directly. Wherever certain views need to be hidden asINVISIBLEand the other ones asGONEby design, I think it looks more clear than a mix of look-alike(!)is(In)Visibles.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume there is a reason to use "invisible" over the default "gone", but IMO the second option is still much more readable than the inline if with constants, especially when it is repeated many times over and over.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, but most views here are
GONErather thanINVISIBLE. LuckilyisGoneis available too, i'll use that then.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the regular case of visible/gone
isVisiblefunction is prefereble, IMO. Since pretty much all flags are usually "somethingSomethingVisible". "invisible" is an edge-case that warrants the explicit usage.