Skip to content

MS-976 Close event scope after down-syncing a single subject#1302

Merged
luhmirin-s merged 2 commits into
mainfrom
feature/MS-976-down-sync-scope-fix
Aug 6, 2025
Merged

MS-976 Close event scope after down-syncing a single subject#1302
luhmirin-s merged 2 commits into
mainfrom
feature/MS-976-down-sync-scope-fix

Conversation

@luhmirin-s
Copy link
Copy Markdown
Contributor

@luhmirin-s luhmirin-s commented Aug 5, 2025

JIRA ticket
Will be released in: 2025.3.0

Root cause analysis (for bugfixes only)

First known affected version: 2024.1.0

  • There was a discrepancy in the number of requests and upsynced events for those requests.
  • Turns out we forgot to properly close event scopes.

Notable changes

  • Added scope closing after subject request.
  • Also force-close all existing down sync in the worker before creating a new one.

Additional work checklist

  • Effect on other features and security has been considered
  • Design document marked as "In development" (if applicable)
  • External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
  • Test cases in Testiny are up to date (or ticket created)
  • Other teams notified about the changes (if applicable)

@cla-bot cla-bot Bot added the ... label Aug 5, 2025
@luhmirin-s luhmirin-s marked this pull request as ready for review August 5, 2025 11:07
@luhmirin-s luhmirin-s requested review from a team, BurningAXE, TristramN, alex-vt, alexandr-simprints, meladRaouf and ybourgery and removed request for a team August 5, 2025 11:07
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 5, 2025

@luhmirin-s luhmirin-s merged commit d2e93d1 into main Aug 6, 2025
13 checks passed
@luhmirin-s luhmirin-s deleted the feature/MS-976-down-sync-scope-fix branch August 6, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants