MS-854 Reducing duplication in capture live feedback classes#1303
Conversation
luhmirin-s
requested review from
a team,
BurningAXE,
TristramN,
alex-vt,
alexandr-simprints,
meladRaouf and
ybourgery
and removed request for
a team
| operator fun invoke(projectConfiguration: ProjectConfiguration): Boolean { | ||
| val isFeatureEnabled = projectConfiguration.experimental().faceAutoCaptureEnabled | ||
| val isOptionTurnedOnInSettings = preference.getBoolean(AUTO_CAPTURE_PREFERENCE_KEY, true) | ||
| return isFeatureEnabled && isOptionTurnedOnInSettings |
There was a problem hiding this comment.
Minor performance issue that's also present in the previous implementation - if isOptionTurnedOnInSettings is extracted as a function and placed inside the return statement, it will never be read when isFeatureEnabled is false (thus sparing shared preferences loading, reading & parsing).
luhmirin-s
force-pushed
the
feature/MS-854-capture-code-refactor
branch
from
627a35f to
cacbd23
Compare
| * to speed things up this method creates multiple async jobs and run them all in parallel. | ||
| * | ||
| * Auto-capture generates a number of sample captures that typically significantly exceeds samplesToKeep. | ||
| * Thus the non-qualifying samples are excluded to avoid excessive event data. |
There was a problem hiding this comment.
Hm, I don't see this comment reflected in the function (neither here, nor in the old file)!?
There was a problem hiding this comment.
Hmm, I didn't look too closely at that comment when merging the files. I agree with you.
BurningAXE
left a comment
BurningAXE
left a comment
There was a problem hiding this comment.
We should pay special attention to this during next release testing to ensure we didn't break anything. Would be nice if @alex-vt takes a look when back, even if PR is already merged.
luhmirin-s
force-pushed
the
feature/MS-854-capture-code-refactor
branch
from
cacbd23 to
616c827
Compare
|
@BurningAXE @alex-vt I will leave it open for now and re-assign the task to Oleksii. Feel free to fix it up and/or merge at any time. |
luhmirin-s
force-pushed
the
feature/MS-854-capture-code-refactor
branch
from
616c827 to
d4cfbc1
Compare
|
3 participants
JIRA ticket
Will be released in: 2025.3.0
Notable changes
Testing guidance
Additional work checklist