MS-109 Add custom field for installed version history tracking#1304
Merged
Conversation
luhmirin-s
requested review from
a team,
BurningAXE,
TristramN,
alex-vt,
alexandr-simprints,
meladRaouf and
ybourgery
and removed request for
a team
BurningAXE
approved these changes
Aug 7, 2025
| import android.content.Context.MODE_PRIVATE | ||
| import androidx.core.content.edit | ||
|
|
||
| class GetCachedVersionNamesUseCase { |
Contributor
There was a problem hiding this comment.
Nice way of auto-updating version history! However, in general I'd avoid having a get function have lots of side effects and writes. Maybe something like UpdateAndGetVersionHistory, GetUpdatedVersionHistory, etc would convey the meaning better.
Contributor
Author
There was a problem hiding this comment.
I can rename it to "FetchVersionHistoryUseCase" to keep it simple.
Contributor
There was a problem hiding this comment.
I see you've updated it to UpdateAndGetVersionHistoryUseCase - that's clearer IMO 👍
luhmirin-s
force-pushed
the
feature/MS-109-version-history-cache
branch
from
6cfefcb to
87af048
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket
Will be released in: 2025.3.0
Notable changes
Testing guidance
Additional work checklist