Skip to content

[MS-1151] Sync UI: Layout adjustment for big numbers on counters to fit#1354

Merged
alex-vt merged 1 commit into
mainfrom
sync-ui-numbers-fit
Sep 8, 2025
Merged

[MS-1151] Sync UI: Layout adjustment for big numbers on counters to fit#1354
alex-vt merged 1 commit into
mainfrom
sync-ui-numbers-fit

Conversation

@alex-vt
Copy link
Copy Markdown
Contributor

@alex-vt alex-vt commented Sep 8, 2025

JIRA ticket
Will be released in: 2025.3.0

Root cause analysis (for bugfixes only)

First known affected version: 2025.2.0, dev-only

  • Numbers of events or images had fixed width
  • On sode devices big (5+ digits) numbers didn't fit in one line

Notable changes

  • Numbers of events or images fit in one line
  • In the edge case when the text to the left of the number doesn't fit, that text gets ellipsized. Example, exaggerated:

Testing guidance

  • See sync info when there are many events, 10000+. The number should fit

Additional work checklist

  • Effect on other features and security has been considered
  • Design document marked as "In development" (if applicable)
  • External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
  • Test cases in Testiny are up to date (or ticket created)
  • Other teams notified about the changes (if applicable)

android:textColor="@color/simprints_text_orange" />

<LinearLayout
<RelativeLayout
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason not to use ConstraintLayout instead?

Copy link
Copy Markdown
Contributor Author

@alex-vt alex-vt Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RelativeLayour should be simpler or similar here.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that is the only reason, then I will insist on using ConstraintLayout. It provides the same controls and much more - chain and bias would be the most relevant parts - and it is much more efficient in measure/layout performance (RelativeLayout optimisation has been abandoned since the ConstraintLayout release, it is effectively deprecated).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luhmirin-s It can be done but we are about to spiral into the dynamic of how the #1282 review went. In this case, ConstraintLayout means a complete rewrite, in the case of a quick edge case fix. Confirm rewrite?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not even close to that scale. The change I ask for should not take long at all, and we will avoid pushing an outdated solution to main.

Copy link
Copy Markdown
Contributor

@luhmirin-s luhmirin-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the other comment, please use the ConstraintLayout.

@alex-vt alex-vt force-pushed the sync-ui-numbers-fit branch from 47fdbb4 to c070b6b Compare September 8, 2025 14:08
@alex-vt alex-vt requested a review from luhmirin-s September 8, 2025 14:09
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Sep 8, 2025

@alex-vt alex-vt merged commit b26a6d4 into main Sep 8, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants