[MS-1145] Visual sync button responsiveness optimization#1356
Merged
Conversation
BurningAXE
reviewed
Sep 9, 2025
| } | ||
| } | ||
|
|
||
| private fun SyncInfo.forceEventSync() = copy( |
Contributor
There was a problem hiding this comment.
Would forceEventSyncProgress() be more precise here?
Contributor
Author
There was a problem hiding this comment.
As this is resolved too, and nothing else to resolve - I'll merge.
3f82e9e to
5eebb52
Compare
|
luhmirin-s
approved these changes
Sep 10, 2025
| * This may take seconds on slow devices. | ||
| * | ||
| * How it works with the optimization: | ||
| * Each forced sync, invoked by forceEventSync and toggleImageSync, immediately reshapes the flow of events: |
Contributor
There was a problem hiding this comment.
IMO, only this paragraph is relevant; the rest can be pruned.
Also, this is not a KDoc comment, so it should not have the double star at the beginning.
Contributor
Author
There was a problem hiding this comment.
Removed the double star, but let's stay a bit more descriptive than usual about this non-trivial feature. There's been a history of more comments requested in similar situations rather than less.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



JIRA ticket
Will be released in: 2025.3.0
Root cause analysis (for bugfixes only)
First known affected version: 2025.3.0 dev only
Notable changes
Testing guidance
Additional work checklist