Skip to content

[MS-1156] Change TokenizableString from Parcelable to Serializable#1357

Merged
meladRaouf merged 1 commit into
release/2025.3.0from
MS-1156-tocknizatoin-params-issue
Sep 10, 2025
Merged

[MS-1156] Change TokenizableString from Parcelable to Serializable#1357
meladRaouf merged 1 commit into
release/2025.3.0from
MS-1156-tocknizatoin-params-issue

Conversation

@meladRaouf
Copy link
Copy Markdown
Collaborator

@meladRaouf meladRaouf commented Sep 9, 2025

JIRA ticket
Will be released in: 2025.3.0

Root cause analysis (for bugfixes only)

  • First known affected version: 2025.3.0
  • Check the jira ticket for more info on how to get this issue.

Notable changes

  • This PR fixes a crash that occurs when the app is moved to the background during the login flow. The crash is caused by a NotSerializableException for TokenizableString.Raw because LoginParams implements StepParams (which is Serializable) but TokenizableString and its subclasses were not serializable.
  • Reason for not using Parcelable:
    The StepParams interface is used widely across the app and is already Serializable. Converting everything to Parcelable would require refactoring all existing StepParams implementations,

Testing guidance

  • Login and move the app to background and restore it should be OK

Additional work checklist

  • Effect on other features and security has been considered
  • Design document marked as "In development" (if applicable)
  • External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
  • Test cases in Testiny are up to date (or ticket created)
  • Other teams notified about the changes (if applicable)

@cla-bot cla-bot Bot added the ... label Sep 9, 2025
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Sep 9, 2025

@luhmirin-s
Copy link
Copy Markdown
Contributor

Should this be on the release branch?

@meladRaouf meladRaouf requested review from a team, BurningAXE, TristramN, alex-vt, alexandr-simprints and ybourgery and removed request for a team September 10, 2025 06:45
@meladRaouf meladRaouf changed the base branch from main to release/2025.3.0 September 10, 2025 06:47
@meladRaouf meladRaouf merged commit bc46a2d into release/2025.3.0 Sep 10, 2025
13 checks passed
@meladRaouf meladRaouf deleted the MS-1156-tocknizatoin-params-issue branch September 10, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants