Move showProgressNotification() to be the first thing in Workers' doW…#1368
Merged
BurningAXE merged 1 commit intoSep 23, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR moves the showProgressNotification() call to be the first statement in each Worker's doWork() method, appearing before crashlyticsLog("Started"), to prevent timeout crashes.
- Reorders initialization sequence in worker classes to show progress notification first
- Ensures progress notification displays immediately when workers start
- Addresses a specific timeout crash issue by prioritizing user-visible feedback
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ProjectConfigDownSyncWorker.kt | Moves showProgressNotification() before crashlyticsLog() |
| DeviceConfigDownSyncWorker.kt | Moves showProgressNotification() before crashlyticsLog() |
| EventUpSyncUploaderWorker.kt | Moves showProgressNotification() before crashlyticsLog() |
| EventSyncMasterWorker.kt | Moves showProgressNotification() before crashlyticsLog() |
| EventStartSyncReporterWorker.kt | Moves showProgressNotification() before crashlyticsLog() |
| EventEndSyncReporterWorker.kt | Moves showProgressNotification() before crashlyticsLog() |
| BaseEventDownSyncDownloaderWorker.kt | Moves showProgressNotification() before crashlyticsLog() |
| RealmToRoomMigrationWorker.kt | Reorders multiple initialization calls including showProgressNotification() |
| StoreUserLocationIntoCurrentSessionWorker.kt | Moves showProgressNotification() before crashlyticsLog() |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
4157c78 to
ae571b8
Compare
luhmirin-s
approved these changes
Sep 23, 2025
…ork() to avoid timeout crash
ae571b8 to
062a1f5
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



JIRA ticket
Will be released in: 2025.3.0
Root cause analysis (for bugfixes only)
First known affected version: 2025.3.0-dev
Notable changes
Testing guidance
Additional work checklist