[MS-1165] MF-ID: QR scanner screen#1369
Merged
alexandr-simprints merged 14 commits intoSep 24, 2025
Merged
Conversation
…fragmetns now use unified Camera reader and Image analyzers from 'ui-base' moduleˆ
alexandr-simprints
requested review from
BurningAXE,
alex-vt,
luhmirin-s and
meladRaouf
luhmirin-s
reviewed
Sep 22, 2025
Contributor
luhmirin-s
left a comment
luhmirin-s
left a comment
There was a problem hiding this comment.
LGTM, left a couple of comments for your consideration.
The only reason not to approve right away is the comment about the placement of QR code in the ui-base.
alexandr-simprints
changed the title
alexandr-simprints
deleted the
MS-1165-mf-id-implementation-qr-scanner
branch
3 tasks
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket
Will be released in: 2025.4.0
Notable changes
QR Analyzer the from login screen is extracted to a common module in
ui-basefeature.This allows the same QR Code analyzer and detector to be used on the Login screen, and
QR Analyzer now has a
CropConfigclass that allows to specify what part of the full image to analyze.This is a requirement for the Multi-Factor Identification workflow, as the HEW might have mutiple QRs in frame, and we would like to minimize the scanned area to a cut-out in the middle of the screen.
CropConfigallows to pass coordinates of the cut-out rectangle within the screen, alongside device's orientation and image resolution.Additional work checklist