Don't require connection for event sync if CommCare downsync source is configured#1371
Merged
BurningAXE merged 1 commit intoSep 23, 2025
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the EventSyncMasterWorker was preventing CommCare downsync from functioning due to unnecessary network connection requirements.
Key changes:
- Modified event sync scheduling to conditionally set network constraints based on whether CommCare downsync is configured
- Made event sync methods suspend functions to allow async configuration retrieval
- Updated debug UI to handle the new suspend function calls
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| SyncOrchestratorImpl.kt | Added dynamic network constraint logic and made event sync methods suspend |
| SyncOrchestrator.kt | Updated interface to make event sync methods suspend functions |
| DebugFragment.kt | Added coroutine scope launches to handle suspend function calls |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
6776c48 to
fab3f77
Compare
|
luhmirin-s
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



JIRA ticket
Will be released in: 2025.3.0
Root cause analysis (for bugfixes only)
First known affected version: 2025.3.0-dev
defaultWorkerConstraintsthat setNetworkType.CONNECTEDCommCareEventSyncDownloaderWorkeris indeed built with no network connection constraintEventSyncMasterWorkerrequires connection so it never runs to buildCommCareEventSyncDownloaderWorkerNotable changes
SyncOrchestratorImpl(either periodic or one time) we check if CommCare downsync source is configured and set connection constraints accordinglyTesting guidance
Additional work checklist