Skip to content

MS-1179 Update auto-capture UI state on resume after settings #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luhmirin-s merged 1 commit into from
Sep 23, 2025
Merged

MS-1179 Update auto-capture UI state on resume after settings #1372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions ...ure/src/main/java/com/simprints/face/capture/screens/livefeedback/LiveFeedbackFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,11 +117,7 @@ internal class LiveFeedbackFragment : Fragment(R.layout.fragment_live_feedback)
vm.initCapture(mainVm.bioSDK, mainVm.samplesToCapture, mainVm.attemptNumber)
}
}
if (vm.isAutoCapture) {
// Await until capture button is pressed
vm.holdOffAutoCapture()
binding.captureFeedbackBtn.isClickable = true
}
enableCaptureButtonIfAutoCapture()

binding.captureInstructionsBtn.setOnClickListener {
findNavController().navigateSafely(
Expand Down Expand Up @@ -185,9 +181,12 @@ internal class LiveFeedbackFragment : Fragment(R.layout.fragment_live_feedback)

override fun onResume() {
super.onResume()

when {
requireActivity().hasPermission(Manifest.permission.CAMERA) -> setUpCamera()
requireActivity().hasPermission(Manifest.permission.CAMERA) -> {
setUpCamera()
enableCaptureButtonIfAutoCapture()
}

mainVm.shouldCheckCameraPermissions.getAndSet(false) -> {
// Check permission in onResume() so that if user left the app to go to Settings
// and give the permission, it's reflected when they come back to SID
Expand All @@ -202,6 +201,14 @@ internal class LiveFeedbackFragment : Fragment(R.layout.fragment_live_feedback)
}
}

private fun enableCaptureButtonIfAutoCapture() {
if (vm.isAutoCapture) {
// Await until capture button is pressed
vm.holdOffAutoCapture()
binding.captureFeedbackBtn.isClickable = true
}
}

override fun onStop() {
toggleTorche(false)
// Shut down our background executor
Expand Down