Prevent endless loop when initial sync is required#1373
Merged
BurningAXE merged 1 commit intoSep 23, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an endless loop bug in the SyncInfoViewModel that occurs when an initial sync is required during startup. The fix adds a parameter to control whether the sync button click event should be emitted, preventing the loop while maintaining the sync functionality.
- Added a boolean parameter
canEmitSyncButtonClickto theforceEventSyncmethod - Modified the initial sync logic to pass
falsefor this parameter to prevent event emission - Removed unused imports related to the previous implementation
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
luhmirin-s
approved these changes
Sep 23, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



JIRA ticket
Will be released in: 2025.3.0
Root cause analysis (for bugfixes only)
First known affected version: 2025.3.0-dev
Notable changes
eventSyncButtonClickFlowto prevent the loopTesting guidance
Additional work checklist