Skip to content

Prevent endless loop when initial sync is required#1373

Merged
BurningAXE merged 1 commit into
release/2025.3.0from
bugfix/prevent-endless-loop-in-SyncInfoViewModel
Sep 23, 2025
Merged

Prevent endless loop when initial sync is required#1373
BurningAXE merged 1 commit into
release/2025.3.0from
bugfix/prevent-endless-loop-in-SyncInfoViewModel

Conversation

@BurningAXE
Copy link
Copy Markdown
Contributor

@BurningAXE BurningAXE commented Sep 23, 2025

JIRA ticket
Will be released in: 2025.3.0

Root cause analysis (for bugfixes only)

First known affected version: 2025.3.0-dev

  • When the SyncInfoViewModel is started and an initial sync is required, it triggers an endless loop

Notable changes

  • Initial sync doesn't emit on eventSyncButtonClickFlow to prevent the loop

Testing guidance

  • Describe how the reviewers can verify that issue is fixed

Additional work checklist

  • Effect on other features and security has been considered
  • Design document marked as "In development" (if applicable)
  • External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
  • Test cases in Testiny are up to date (or ticket created)
  • Other teams notified about the changes (if applicable)

@cla-bot cla-bot Bot added the ... label Sep 23, 2025
@BurningAXE BurningAXE requested a review from Copilot September 23, 2025 14:48
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an endless loop bug in the SyncInfoViewModel that occurs when an initial sync is required during startup. The fix adds a parameter to control whether the sync button click event should be emitted, preventing the loop while maintaining the sync functionality.

  • Added a boolean parameter canEmitSyncButtonClick to the forceEventSync method
  • Modified the initial sync logic to pass false for this parameter to prevent event emission
  • Removed unused imports related to the previous implementation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@BurningAXE BurningAXE marked this pull request as ready for review September 23, 2025 14:51
@BurningAXE BurningAXE requested review from a team, TristramN, alex-vt, alexandr-simprints, luhmirin-s, meladRaouf and ybourgery and removed request for a team September 23, 2025 14:51
@sonarqubecloud
Copy link
Copy Markdown

@BurningAXE BurningAXE merged commit fbeaba3 into release/2025.3.0 Sep 23, 2025
13 checks passed
@luhmirin-s luhmirin-s deleted the bugfix/prevent-endless-loop-in-SyncInfoViewModel branch September 24, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants