Add showProgressNotification() to workers that don't have it#1375
Merged
BurningAXE merged 1 commit intoSep 25, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds progress notification functionality to background workers that were missing this feature. The change ensures consistent user experience across all sync workers by displaying progress notifications when they execute.
- Adds
showProgressNotification()calls to three sync workers - Ensures consistent progress notification behavior across all background workers
- Maintains the established pattern of showing notifications before logging the start of work
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| FirmwareFileUpdateWorker.kt | Added progress notification call at the beginning of doWork() method |
| FileUpSyncWorker.kt | Added progress notification call at the beginning of doWork() method |
| EnrolmentRecordWorker.kt | Added progress notification call at the beginning of doWork() method |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
luhmirin-s
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



JIRA ticket
Will be released in: 2025.3.0
Root cause analysis (for bugfixes only)
First known affected version: unknown
showProgressNotification()call at allNotable changes
showProgressNotification()first thing in these Workers' doWork()Testing guidance
Additional work checklist