Skip to content

Add showProgressNotification() to workers that don't have it#1375

Merged
BurningAXE merged 1 commit into
release/2025.3.0from
bugfix/foreground-service-timeout-crash2
Sep 25, 2025
Merged

Add showProgressNotification() to workers that don't have it#1375
BurningAXE merged 1 commit into
release/2025.3.0from
bugfix/foreground-service-timeout-crash2

Conversation

@BurningAXE
Copy link
Copy Markdown
Contributor

@BurningAXE BurningAXE commented Sep 24, 2025

JIRA ticket
Will be released in: 2025.3.0

Root cause analysis (for bugfixes only)

First known affected version: unknown

  • 3 workers (image sync being the most notable one) didn't have the showProgressNotification() call at all
  • I suspect that image sync taking more than 5-10 seconds was what caused all/most crashes

Notable changes

  • Added showProgressNotification() first thing in these Workers' doWork()

Testing guidance

  • Open the Sync Info screen and start tapping the two sync buttons like crazy for a few minutes. If no crash - celebrate!

Additional work checklist

  • Effect on other features and security has been considered
  • Design document marked as "In development" (if applicable)
  • External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
  • Test cases in Testiny are up to date (or ticket created)
  • Other teams notified about the changes (if applicable)

@cla-bot cla-bot Bot added the ... label Sep 24, 2025
@BurningAXE BurningAXE requested a review from Copilot September 24, 2025 16:34
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds progress notification functionality to background workers that were missing this feature. The change ensures consistent user experience across all sync workers by displaying progress notifications when they execute.

  • Adds showProgressNotification() calls to three sync workers
  • Ensures consistent progress notification behavior across all background workers
  • Maintains the established pattern of showing notifications before logging the start of work

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
FirmwareFileUpdateWorker.kt Added progress notification call at the beginning of doWork() method
FileUpSyncWorker.kt Added progress notification call at the beginning of doWork() method
EnrolmentRecordWorker.kt Added progress notification call at the beginning of doWork() method

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@BurningAXE BurningAXE marked this pull request as ready for review September 24, 2025 16:41
@sonarqubecloud
Copy link
Copy Markdown

@BurningAXE BurningAXE requested review from a team, TristramN, alex-vt, alexandr-simprints, luhmirin-s, meladRaouf and ybourgery and removed request for a team September 24, 2025 16:46
@BurningAXE BurningAXE merged commit b6ecbd9 into release/2025.3.0 Sep 25, 2025
13 checks passed
@meladRaouf meladRaouf deleted the bugfix/foreground-service-timeout-crash2 branch September 25, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants