[MS-1164] Multi-Factor ID. OCR Scanner screen#1379
Merged
alexandr-simprints merged 17 commits intoSep 30, 2025
Merged
Conversation
…ments (camera, image analyzer) are no longer passed to the ViewModel so that configuration changes can be properly applied. Same with permissions
alexandr-simprints
requested review from
BurningAXE,
alex-vt,
luhmirin-s and
meladRaouf
luhmirin-s
reviewed
Sep 29, 2025
| import javax.inject.Inject | ||
| import kotlin.math.min | ||
|
|
||
| internal class CalculateLevenshteinDistanceUseCase @Inject constructor() { |
Contributor
There was a problem hiding this comment.
Could this be done as a top-level function directly? Could skip some of the injection overhead for a purely mathematical function.
Contributor
Author
There was a problem hiding this comment.
I'd rather keep the Levenshtein Distance calculations as a separate use case for testing isolation purposes. Declaring a single injectable field doesn't seem like a great injection overhead
Contributor
There was a problem hiding this comment.
Having this as a function does not hurt testing since it is a pure function - it can be tested the same way, and there is no need to mock it since there are no internal dependencies.
… to avoid unnecessary computations when strings are equal
luhmirin-s
approved these changes
Sep 30, 2025
Contributor
luhmirin-s
left a comment
luhmirin-s
left a comment
There was a problem hiding this comment.
LGTM, rest of the comments are nice-to-haves.
…ement. 'return' usually for the closest scope block, which in this case is the "forEach"
…It now accepts target length of the credential to filter out incorrect readouts from the pool
… to avoid extra calculationsˆ
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket
Will be released in: 2025.4.0
Notable changes
Implementation of the document scanner that uses OCR (Optical Character Recognition) approach to extract an external credential from the document using Google's ML kit.
Additional work checklist