Skip to content

MS-1188 Short-term logout fix#1381

Merged
luhmirin-s merged 3 commits into
release/2025.3.0from
feature/MS-1188-logout-fix
Sep 30, 2025
Merged

MS-1188 Short-term logout fix#1381
luhmirin-s merged 3 commits into
release/2025.3.0from
feature/MS-1188-logout-fix

Conversation

@luhmirin-s
Copy link
Copy Markdown
Contributor

@luhmirin-s luhmirin-s commented Sep 30, 2025

JIRA ticket
Will be released in: 2025.3.0

Root cause analysis (for bugfixes only)

First known affected version: 2025.3.0

  • Compounded issue that leads to some racing:
    • In both cases, the logout use case is called in the view model-scoped coroutine. Navigation happens right after the start of the logout coroutine, which kills the VM scope and cancels the logout navigation (sometimes, this is the racing part).
    • Navigation to the root leads to checking for "logged in" state (which succeeds if navigation happened faster than the data cleanup) and opens the dashboard instead of the "login request" placeholder.

Notable changes

  • Made logout use case blocking (while still executing on the IO dispatcher) to block navigation until the data cleanup is done.
  • Minor cleanup of the navigation graph actions to make it consistent.

Testing guidance

  • Login, do biometric flow (so that event upload is forced), attempt to log out. Repeat multiple times.
  • Should navigate to the login request screen every time.

Additional work checklist

  • Effect on other features and security has been considered
  • Design document marked as "In development" (if applicable)
  • External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
  • Test cases in Testiny are up to date (or ticket created)
  • Other teams notified about the changes (if applicable)

@luhmirin-s luhmirin-s requested review from a team, BurningAXE, TristramN, alex-vt, alexandr-simprints, meladRaouf and ybourgery and removed request for a team September 30, 2025 09:32
@cla-bot cla-bot Bot added the ... label Sep 30, 2025
@luhmirin-s luhmirin-s changed the base branch from main to release/2025.3.0 September 30, 2025 09:40
@sonarqubecloud
Copy link
Copy Markdown

@luhmirin-s luhmirin-s merged commit 207e08b into release/2025.3.0 Sep 30, 2025
22 of 23 checks passed
@luhmirin-s luhmirin-s deleted the feature/MS-1188-logout-fix branch September 30, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants