[MS-1170] MF-ID: Confirm Identity Credential save#1396
Merged
alexandr-simprints merged 12 commits intoOct 9, 2025
Merged
Conversation
…w with ability to add external credentialˆ
…low with ability to add external credential
…0-mf-id-implementation-confirm-identity-credential-save # Conflicts: # feature/external-credential/src/main/java/com/simprints/feature/externalcredential/ext/ViewExt.kt # feature/external-credential/src/main/java/com/simprints/feature/externalcredential/screens/scanocr/ExternalCredentialScanOcrFragment.kt # feature/external-credential/src/main/java/com/simprints/feature/externalcredential/screens/scanocr/ExternalCredentialScanOcrViewModel.kt # feature/external-credential/src/main/java/com/simprints/feature/externalcredential/screens/select/ExternalCredentialSelectFragment.kt # feature/external-credential/src/test/java/com/simprints/feature/externalcredential/screens/controller/ExternalCredentialViewModelTest.kt # feature/orchestrator/src/main/java/com/simprints/feature/orchestrator/usecases/response/CreateEnrolResponseUseCase.kt
…0-mf-id-implementation-confirm-identity-credential-save # Conflicts: # feature/external-credential/src/main/java/com/simprints/feature/externalcredential/screens/controller/ExternalCredentialViewModel.kt # feature/external-credential/src/main/java/com/simprints/feature/externalcredential/screens/scanocr/usecase/GetCredentialCoordinatesUseCase.kt # feature/external-credential/src/main/java/com/simprints/feature/externalcredential/screens/scanocr/usecase/SaveScannedImageUseCase.kt # feature/external-credential/src/test/java/com/simprints/feature/externalcredential/screens/scanocr/usecase/KeepOnlyBestDetectedBlockUseCaseTest.kt # feature/external-credential/src/test/java/com/simprints/feature/externalcredential/screens/scanocr/usecase/SaveScannedImageUseCaseTest.kt
…edential feature module
alexandr-simprints
changed the title
…ion-confirm-identity-credential-save
alexandr-simprints
requested review from
BurningAXE,
alex-vt,
luhmirin-s and
meladRaouf
and removed request for
luhmirin-s and
meladRaouf
luhmirin-s
reviewed
Oct 8, 2025
…g sessionCoroutineScope for saving event
luhmirin-s
approved these changes
Oct 9, 2025
Contributor
luhmirin-s
left a comment
luhmirin-s
left a comment
There was a problem hiding this comment.
One more place with incorrect scope, LGTM otherwise.
|
alexandr-simprints
deleted the
MS-1170-mf-id-implementation-confirm-identity-credential-save
branch
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket
Will be released in: 2025.4.0
Notable changes
ActionResponse.ConfirmActionResponsestructure is updated inLibSimprintsResponseMapper. It now contains"hasCredential"boolean field, and a nullable"scannedCredential"json field.SelectSubjectFragment. It is visible if a credential has to be added to the subjectUI preview
Portrait. Phone, tablet:
Landscape. Phone, tablet:
Additional work checklist