Log full filename instead of just last char#1404
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a logging issue where only the last character of the filename was being logged instead of the full filename during image uploads.
- Changed logging to use the full filename from the relative path instead of just the last character
- Improved debugging visibility by showing complete filenames in upload logs
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| .fold(rootRef) { ref, pathPart -> ref.child(pathPart) } | ||
|
|
||
| Simber.i("Uploading ${fileRef.path.last()}", tag = SAMPLE_UPLOAD) | ||
| Simber.i("Uploading ${imageRef.relativePath.parts.last()}", tag = SAMPLE_UPLOAD) |
There was a problem hiding this comment.
The fix assumes imageRef.relativePath.parts is non-empty, but if the list is empty, last() will throw a NoSuchElementException. Consider using lastOrNull() or adding a null check to prevent runtime crashes.
Suggested change
| Simber.i("Uploading ${imageRef.relativePath.parts.last()}", tag = SAMPLE_UPLOAD) | |
| Simber.i("Uploading ${imageRef.relativePath.parts.lastOrNull() ?: "<unknown>"}", tag = SAMPLE_UPLOAD) |
meladRaouf
approved these changes
Oct 13, 2025
luhmirin-s
approved these changes
Oct 13, 2025
b1cf110 to
24e48f8
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



JIRA ticket
Will be released in: 2025.3.0
Root cause analysis (for bugfixes only)
First known affected version: 2025.3.0-dev
Notable changes
Testing guidance
Additional work checklist