Expand step param and result integration tests to ensure all classes serialise correctly#1406
Merged
Merged
Conversation
BurningAXE
approved these changes
Oct 15, 2025
| val format: String, | ||
| ) : StepResult | ||
| ) : StepResult { | ||
| override fun equals(other: Any?): Boolean { |
Contributor
There was a problem hiding this comment.
Why is this needed? And will we need to do it for all subclasses? :(
Contributor
Author
There was a problem hiding this comment.
Automatic data class "equals" implementation does not work with arrays (there is even a warning that we usually ignore). Without this, comparing data in tests becomes a major PITA.
It is only required when there are arrays in data classes.
…serialise correctly
ccde3c0 to
bcbcf3b
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Will be released in: 2025.3.0
Root cause analysis (for bugfixes only)
First known affected version: 2025.3.0
Notable changes
Additional work checklist