Skip to content

Expand step param and result integration tests to ensure all classes serialise correctly#1406

Merged
luhmirin-s merged 1 commit into
release/2025.3.0from
hotfix/step-serialising-fixes
Oct 15, 2025
Merged

Expand step param and result integration tests to ensure all classes serialise correctly#1406
luhmirin-s merged 1 commit into
release/2025.3.0from
hotfix/step-serialising-fixes

Conversation

@luhmirin-s
Copy link
Copy Markdown
Contributor

Will be released in: 2025.3.0

Root cause analysis (for bugfixes only)

First known affected version: 2025.3.0

  • When the step orchestrator cache restores step data, sometimes not all of the classes can be restored correctly.

Notable changes

  • Added all of the step param and result classes to the orchestrator cache integration tests to make sure that all are written and read correctly.
  • Fixes for a couple of classes that were not deserialising correctly.

Additional work checklist

  • Effect on other features and security has been considered
  • Design document marked as "In development" (if applicable)
  • External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
  • Test cases in Testiny are up to date (or ticket created)
  • Other teams notified about the changes (if applicable)

@luhmirin-s luhmirin-s requested review from a team, BurningAXE, TristramN, alex-vt, alexandr-simprints, meladRaouf and ybourgery and removed request for a team October 15, 2025 12:59
@cla-bot cla-bot Bot added the ... label Oct 15, 2025
val format: String,
) : StepResult
) : StepResult {
override fun equals(other: Any?): Boolean {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed? And will we need to do it for all subclasses? :(

Copy link
Copy Markdown
Contributor Author

@luhmirin-s luhmirin-s Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatic data class "equals" implementation does not work with arrays (there is even a warning that we usually ignore). Without this, comparing data in tests becomes a major PITA.

It is only required when there are arrays in data classes.

@luhmirin-s luhmirin-s force-pushed the hotfix/step-serialising-fixes branch from ccde3c0 to bcbcf3b Compare October 15, 2025 13:18
@sonarqubecloud
Copy link
Copy Markdown

@luhmirin-s luhmirin-s merged commit fc0d946 into release/2025.3.0 Oct 15, 2025
13 checks passed
@luhmirin-s luhmirin-s deleted the hotfix/step-serialising-fixes branch October 15, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants