Skip to content

[MS-1166] MF-ID: Skip Form screen#1408

Merged
alexandr-simprints merged 15 commits into
MS-1169-mf-id-implementation-enrol-last-credential-savefrom
MS-1166-mf-id-implementation-skip-screen
Oct 20, 2025
Merged

[MS-1166] MF-ID: Skip Form screen#1408
alexandr-simprints merged 15 commits into
MS-1169-mf-id-implementation-enrol-last-credential-savefrom
MS-1166-mf-id-implementation-skip-screen

Conversation

@alexandr-simprints
Copy link
Copy Markdown
Contributor

@alexandr-simprints alexandr-simprints commented Oct 15, 2025 •
edited by atlassian Bot
Loading

JIRA ticket
Will be released in: 2025.4.0

Notable changes

  • External credential scan step can now be skipped with a reason
  • The reason is not yet saved anywhere in the app. Currently, skipping results in ScannedCredential being null in the response.
  • Skip Reasons should be considered during the event coverage implementation in MS-1168

UI Preview

image image image

Additional work checklist

  • Effect on other features and security has been considered
  • Design document marked as "In development" (if applicable)
  • External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)

@alexandr-simprints
[MS-1166] Initial implementation of the Skip Credential screen
d16651b
@alexandr-simprints
[MS-1166] Adding analytical reminder comment
8642b58
@alexandr-simprints
[MS-1189] Adding MFID-specific consent text
261bec8
@alexandr-simprints
Merge branch 'MS-1169-mf-id-implementation-enrol-last-credential-save…
1b2d76c 
…' into MS-1166-mf-id-implementation-skip-screen
@alexandr-simprints
Merge branch 'MS-1166-mf-id-implementation-skip-screen' into MS-1189-…
cadde42 
…md-id-consent-update
@alexandr-simprints
Merge branch 'MS-1169-mf-id-implementation-enrol-last-credential-save…
5d37b57 
…' into MS-1166-mf-id-implementation-skip-screen
@alexandr-simprints
Merge branch 'MS-1166-mf-id-implementation-skip-screen' into MS-1189-…
97da10e 
…md-id-consent-update
@alexandr-simprints
Merge branch 'MS-1169-mf-id-implementation-enrol-last-credential-save…
86233e3 
…' into MS-1166-mf-id-implementation-skip-screen
@alexandr-simprints
Merge branch 'MS-1166-mf-id-implementation-skip-screen' into MS-1189-…
1f8510a 
…md-id-consent-update
@alexandr-simprints
Merge branch 'MS-1169-mf-id-implementation-enrol-last-credential-save…
11a28c3 
…' into MS-1166-mf-id-implementation-skip-screen
@alexandr-simprints
[MS-1166] Removing old tests, updating existing tests of ExternalCred…
927f18d 
…entialViewModelTest.kt
@cla-bot cla-bot Bot added the ... label Oct 15, 2025
luhmirin-s
luhmirin-s approved these changes Oct 16, 2025
View reviewed changes
Comment thread ...java/com/simprints/feature/externalcredential/screens/skip/ExternalCredentialSkipFragment.kt
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Oct 20, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@alexandr-simprints alexandr-simprints merged commit fab0972 into MS-1169-mf-id-implementation-enrol-last-credential-save Oct 20, 2025
13 checks passed
@alexandr-simprints alexandr-simprints deleted the MS-1166-mf-id-implementation-skip-screen branch October 20, 2025 14:18
@alexandr-simprints alexandr-simprints mentioned this pull request Oct 22, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luhmirin-s luhmirin-s luhmirin-s approved these changes

@alex-vt alex-vt alex-vt approved these changes

@BurningAXE BurningAXE Awaiting requested review from BurningAXE

@meladRaouf meladRaouf Awaiting requested review from meladRaouf

Assignees

No one assigned

Labels

...

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexandr-simprints @luhmirin-s @alex-vt