MS-1205 MFID events#1420
Conversation
| @Keep | ||
| data class ScannedCredential( | ||
| val credentialScanId: String = randomUUID(), | ||
| val credential: TokenizableString.Tokenized, |
There was a problem hiding this comment.
Shall we rename credential to scannedValueEncrypted or something similar to reflect that we have both encrypted and decrypted credential values in the object?
There was a problem hiding this comment.
I think "credential" is fine, it has to be distinct from the "scannedValue" since those are used for very different purposes.
There was a problem hiding this comment.
@BurningAXE since you gave a thumbs up, could you please provide your thoughts on Sergejs' response?
There was a problem hiding this comment.
My reasoning is that credential and scannedValue don't convey that they actually hold the same value in a different "format". The less you need to reason about the code - the better.
luhmirin-s
force-pushed
the
feature/MS-1205-mfid-events-1
branch
from
f46cdfe to
0ba0f98
Compare
luhmirin-s
requested review from
a team,
BurningAXE,
TristramN,
alex-vt,
alexandr-simprints,
meladRaouf and
ybourgery
and removed request for
a team
luhmirin-s
force-pushed
the
feature/MS-1205-mfid-events-1
branch
from
0ba0f98 to
0fe9cb7
Compare
| scannedCredential: ScannedCredential, | ||
| selectionEventId: String, | ||
| ) { | ||
| Simber.d("Saving External Credential Events for $scannedCredential") |
There was a problem hiding this comment.
The ScannedCredential contains the raw credential value and it may get into the logs unredacted, is this safe? Just in case, a similar call is already in the codebase here:
There was a problem hiding this comment.
Hmm, will double-check that none of the d() level logs are preserved.
There was a problem hiding this comment.
Should be safe in staging and release builds:
Logger.setMinSeverity(if (BuildConfig.DEBUG) Severity.Debug else Severity.Info)
luhmirin-s
force-pushed
the
feature/MS-1205-mfid-events-1
branch
from
0fe9cb7 to
59c71d0
Compare
| ExternalCredentialType.QRCode -> InputType.TYPE_CLASS_TEXT | ||
| } | ||
|
|
||
| fun trackRecapture() { |
There was a problem hiding this comment.
@luhmirin-s shouldn't you reset the val startTime here ?
There was a problem hiding this comment.
The recapture navigates to the selection fragment that will reset the respective timestamps in onViewCreated() and subsequent methods.
|
5 participants
JIRA ticket
Will be released in: 2025.4.0
Notable changes
ExternalCredentialSearchEventto track the time it takes to filter and match records by the external credential.ExternalCredentialConfirmationEventto track the time the user spent on the external credential confirmation screen.ExternalCredentialSelectionEventto track the user's decision to do or skip the external credentials flow.ExternalCredentialCaptureEventto correctly reflect the external credential capture flow.Testing guidance
Additional work checklist