[MS-1217] Adding custom OCR configuration#1434
Conversation
alexandr-simprints
requested review from
BurningAXE,
alex-vt,
luhmirin-s and
meladRaouf
ybourgery
left a comment
ybourgery
left a comment
There was a problem hiding this comment.
What is the reason to not put this into the multiFactorId configuration? Is it something that should be temporary?
|
| init { | ||
| viewModelScope.launch { | ||
| ocrConfig = configManager.getProjectConfiguration().experimental().let { config -> | ||
| OcrConfig( |
There was a problem hiding this comment.
Why not return the class directly from the experimental config? MIN/MAX could be defined in the experimental config the same way.
There was a problem hiding this comment.
The settings are feature-related, and the idea was for the feature to provide the configuration data classes within its scope (as done with OcrCropConfig).
Currently, the values are coming from the experimental part of the project configuration, and I'd like to keep them atomic, and not feature-specific.
The idea is to test what project settings work best, and later move the configuration to Vulcan 'MF-ID' tab. That means that this part will be refactored in the following releases, and the only thing that we will need to change is where the setting values are coming from
@ybourgery it is an experimental idea that me and @jonsimprints came up with, and we would like to experiment with the values before asking the Cloud team for the Vulcan implementation. It's not yet certain whether we will need specifically these settings, something else, or none at all |
alexandr-simprints
deleted the
MS-1217-create-custom-config-for-mfid-ocr
branch
4 participants
JIRA ticket
Will be released in: 2025.4.0
Notable changes
OCR configuration can now be set in
Custom Configtab in Vulcan."ocrCaptures": 5- sets how many images to run OCR on. Default is 3. Range: [1, 10]"ocrHighRes": true / false- if true, captures high-res images to run OCR. If false, captures heavily-compressed images from the video feedback.Additional work checklist