Skip to content

[MS-1222] UI Elements no longer resize after fade out animation is finished #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexandr-simprints merged 1 commit into from
Oct 28, 2025
Merged

[MS-1222] UI Elements no longer resize after fade out animation is finished #1435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions ...simprints/feature/externalcredential/screens/scanocr/ExternalCredentialScanOcrFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,8 +232,19 @@ internal class ExternalCredentialScanOcrFragment : Fragment(R.layout.fragment_ex

private fun animateCompletionState() = with(binding) {
isAnimatingCompletion = true
progressBar.fadeOut(FINISH_ANIMATION_DURATION, scaleX = true, fragment = this@ExternalCredentialScanOcrFragment)
scanInstructions.fadeOut(FINISH_ANIMATION_DURATION, scaleX = false, fragment = this@ExternalCredentialScanOcrFragment)
val finalVisibility = View.INVISIBLE
progressBar.fadeOut(
FINISH_ANIMATION_DURATION,
scaleX = true,
fragment = this@ExternalCredentialScanOcrFragment,
finalVisibility = finalVisibility,
)
scanInstructions.fadeOut(
FINISH_ANIMATION_DURATION,
scaleX = false,
fragment = this@ExternalCredentialScanOcrFragment,
finalVisibility = finalVisibility,
)
iconScanComplete.fadeIn(FINISH_ANIMATION_DURATION, fragment = this@ExternalCredentialScanOcrFragment, onComplete = {
isAnimatingCompletion = false
// Execute any pending action after the animation. Currently used is for next fragment navigation
Expand Down
3 changes: 2 additions & 1 deletion infra/ui-base/src/main/java/com/simprints/infra/uibase/view/View.ext.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,14 @@ fun View.fadeOut(
duration: Long,
scaleX: Boolean,
fragment: Fragment,
finalVisibility: Int = View.GONE,
) = animate()
.alpha(0f)
.setDuration(duration)
.setInterpolator(DecelerateInterpolator())
.withEndAction {
if (fragment.isAdded) {
this.isVisible = false
this.visibility = finalVisibility
}
}.also {
if (scaleX) {
Expand Down