Skip to content

MS-1224 closing session on update#1436

Merged
luhmirin-s merged 1 commit into
release/2025.3.0from
feature/MS-1224-closing-session-on-update
Oct 30, 2025
Merged

MS-1224 closing session on update#1436
luhmirin-s merged 1 commit into
release/2025.3.0from
feature/MS-1224-closing-session-on-update

Conversation

@luhmirin-s
Copy link
Copy Markdown
Contributor

@luhmirin-s luhmirin-s commented Oct 29, 2025 •
edited
Loading

JIRA ticket
Will be released in: 2025.3.0

Root cause analysis (for bugfixes only)

First known affected version: 2025.3.0

  • If an identification call was made on 2025.2.0 and a follow-up call made on 2025.3.0 or later, the orchestration steps would fail to unmarshal due to a changed class structure.

Notable changes

  • Clear the orchestration cache and close the current session on application update.

Testing guidance

  • Do an identification call on 2025.2.0 and a follow-up call on the current version.
  • There should be an error message about an invalid session.

Additional work checklist

  • Effect on other features and security has been considered
  • Design document marked as "In development" (if applicable)
  • External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
  • Test cases in Testiny are up to date (or ticket created)
  • Other teams notified about the changes (if applicable)

@luhmirin-s luhmirin-s requested review from a team, BurningAXE, TristramN, alex-vt, alexandr-simprints, meladRaouf and ybourgery and removed request for a team October 29, 2025 13:46
@cla-bot cla-bot Bot added the ... label Oct 29, 2025
@luhmirin-s luhmirin-s force-pushed the feature/MS-1224-closing-session-on-update branch from 26e397d to f1c82f2 Compare October 29, 2025 13:47
BurningAXE
BurningAXE reviewed Oct 29, 2025
View reviewed changes
Comment thread infra/events/src/main/java/com/simprints/infra/events/receivers/SessionTerminationReceiver.kt
timeHelper.ensureTrustworthiness()
if (Intent.ACTION_BOOT_COMPLETED == intent.action) {
if (Intent.ACTION_BOOT_COMPLETED == intent.action || Intent.ACTION_MY_PACKAGE_REPLACED == intent.action) {
closeSessionUseCase()
Copy link
Copy Markdown
Contributor

@BurningAXE BurningAXE Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should directly tie closing the session with resetting caches. Current approach is very cumbersome and prone to breaking. That's probably a rather big change for a hotfix, though.

Copy link
Copy Markdown
Contributor Author

@luhmirin-s luhmirin-s Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I have moved this logic into a dedicated receiver in the orchestration module.

Copy link
Copy Markdown
Contributor

@BurningAXE BurningAXE Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we create a ticket to refactor this in main? I imagine the more robust version like:

  • Have one receiver that listens for package update and closes the session
  • On session close broadcast "Session closed"
  • Have another receiver for "Session closed" that clears the cache
    This will tie things in a way that does not depend on workflows and VMs and would make it kind of more explicit.

Copy link
Copy Markdown
Contributor Author

@luhmirin-s luhmirin-s Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a ticket for future, this seems a bit more than a hotfix: https://simprints.atlassian.net/browse/MS-1232

Copy link
Copy Markdown
Contributor

@BurningAXE BurningAXE Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure not in a hotfix!

@luhmirin-s luhmirin-s force-pushed the feature/MS-1224-closing-session-on-update branch from f1c82f2 to e071976 Compare October 30, 2025 07:52
@luhmirin-s luhmirin-s force-pushed the feature/MS-1224-closing-session-on-update branch from e071976 to bd0ffaf Compare October 30, 2025 11:05
@luhmirin-s luhmirin-s changed the base branch from release/2025.4.0 to release/2025.3.0 October 30, 2025 11:05
@luhmirin-s
Copy link
Copy Markdown
Contributor Author

luhmirin-s commented Oct 30, 2025

@BurningAXE I have moved the fix to 2025.3.0 release branch

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Oct 30, 2025

Quality Gate Passed Quality Gate passed

Issues
28 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.6% Coverage on New Code
0.2% Duplication on New Code

See analysis details on SonarQube Cloud

@luhmirin-s luhmirin-s merged commit 82d3b2d into release/2025.3.0 Oct 30, 2025
13 checks passed
@luhmirin-s luhmirin-s deleted the feature/MS-1224-closing-session-on-update branch October 30, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BurningAXE BurningAXE BurningAXE approved these changes

@alex-vt alex-vt Awaiting requested review from alex-vt alex-vt was automatically assigned from Simprints/sid-reviewers

@TristramN TristramN Awaiting requested review from TristramN TristramN was automatically assigned from Simprints/sid-reviewers

@ybourgery ybourgery Awaiting requested review from ybourgery ybourgery was automatically assigned from Simprints/sid-reviewers

@alexandr-simprints alexandr-simprints Awaiting requested review from alexandr-simprints alexandr-simprints was automatically assigned from Simprints/sid-reviewers

@meladRaouf meladRaouf Awaiting requested review from meladRaouf

Assignees

No one assigned

Labels

...

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@luhmirin-s @BurningAXE @meladRaouf