Skip to content

MS-1228 Enrolment Record update event fix#1448

Merged
luhmirin-s merged 3 commits into
release/2025.4.0from
feature/MS-1228-enrolment-update-fix
Nov 6, 2025
Merged

MS-1228 Enrolment Record update event fix#1448
luhmirin-s merged 3 commits into
release/2025.4.0from
feature/MS-1228-enrolment-update-fix

Conversation

@luhmirin-s
Copy link
Copy Markdown
Contributor

@luhmirin-s luhmirin-s commented Nov 3, 2025

JIRA ticket
Will be released in: version

Notable changes

  • Ensuring that there is exactly one EnrolmentUpdateEvent per session for the last received subject ID confirmation. If the confirmation was for "None", all of the update events are removed from the session.
  • Removing all EnrolmentUpdateEvent and reverting credential links on the last biometric enrolment.
  • Added a method to delete events in the current session.
  • Added a method to remove credentials from the record by the IDs saved in EnrolmentUpdateEvent (explicitly not by value to avoid accidentally removing values from different sessions).

Testing guidance

  • Set the device to offline mode to prevent upsync during the test
  • Do an identification flow with an external credential scan in such a way that there are several subject IDs returned (save several of the IDs).
  • Send confirmation intent with one of the IDs, confirm addition of the external credential. In the troubleshooting screen, check the events in the last intent - it should contain EnrolmentUpdateEvent for the last confirmation.
  • Send confirmation with another subject ID, confirm the addition of the credentials again. In the troubleshooting screen, check the events in the last intent - it should still contain a single EnrolmentUpdateEvent for the last confirmation.
  • Repeat as many times as you want - there should always be a single EnrolmentUpdateEvent for the last confirmation.
  • Send confirmation with "none_selected" instead of UUID. There should be no credential attachment dialog and no EnrolmentUpdateEvent for the last confirmation events.

Additional work checklist

  • Effect on other features and security has been considered
  • Design document marked as "In development" (if applicable)
  • External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
  • Test cases in Testiny are up to date (or ticket created)
  • Other teams notified about the changes (if applicable)

@cla-bot cla-bot Bot added the ... label Nov 3, 2025
@luhmirin-s luhmirin-s force-pushed the feature/MS-1228-enrolment-update-fix branch from 3ba32ba to 2d3cea5 Compare November 3, 2025 14:38
@luhmirin-s luhmirin-s marked this pull request as ready for review November 3, 2025 14:38
@luhmirin-s luhmirin-s requested review from a team, BurningAXE, TristramN, alex-vt, alexandr-simprints, meladRaouf and ybourgery and removed request for a team November 3, 2025 14:39
@ybourgery
Copy link
Copy Markdown
Collaborator

I think you are missing the use-case where we are doing a (or several) confirmation followed by an enrolment last biometrics, in this case it should also remove the existing EnrolmentUpdate events

@luhmirin-s luhmirin-s force-pushed the feature/MS-1228-enrolment-update-fix branch 2 times, most recently from 20bc77a to e76a778 Compare November 4, 2025 07:35
@luhmirin-s
Copy link
Copy Markdown
Contributor Author

@ybourgery added the same session cleanup to enrol last as well.

@luhmirin-s luhmirin-s force-pushed the feature/MS-1228-enrolment-update-fix branch 2 times, most recently from 4571a63 to b335790 Compare November 4, 2025 07:44
@luhmirin-s luhmirin-s force-pushed the feature/MS-1228-enrolment-update-fix branch from b335790 to c0f73aa Compare November 4, 2025 14:18
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Nov 4, 2025

@alexandr-simprints
Copy link
Copy Markdown
Contributor

Great job, thanks for addressing this issue!

@luhmirin-s luhmirin-s merged commit 49598f5 into release/2025.4.0 Nov 6, 2025
13 checks passed
@luhmirin-s luhmirin-s deleted the feature/MS-1228-enrolment-update-fix branch November 6, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants