[MS-1251] Make Simber.w throwable argument non-optional to avoid lumping all warnings together in Crashlytics

[BurningAXE]

JIRA ticket
Will be released in: 2026.1.0

Root cause analysis (for bugfixes only)

First known affected version: forever

• Currently all Simber.w logs are wrapped in a generic Exception which in Crashlytics they are all lumped together into this single issue with 10s of variants. This is very impractical for monitoring and risks hiding real issues among benign ones.

Notable changes

• Makes the Throwable parameter in Simber.w() non-optional in order to force callers to pass a Throwable argument. This will group different call sites together
• All current Simber.w() calls were provided an appropriate exception

Testing guidance

• I guess we'll have to either wait this to reach prod or create a staging build and force some warning scenarios to happen

Additional work checklist

• Effect on other features and security has been considered
• Design document marked as "In development" (if applicable)
• External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
• Test cases in Testiny are up to date (or ticket created)
• Other teams notified about the changes (if applicable)

[Copilot]

Pull Request Overview

This PR addresses a long-standing issue where all warning logs in Crashlytics were grouped together into a single generic issue, making it difficult to monitor and triage different warning scenarios. The solution makes the Throwable parameter in Simber.w() non-optional, forcing callers to provide specific exceptions that will enable proper grouping in Crashlytics.

Key changes:

• Modified Simber.w() to require a non-null Throwable parameter
• Updated all existing call sites to provide appropriate exception types with descriptive messages
• Simplified the internal logging logic by removing the null-handling branch

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
infra/logging/src/main/java/com/simprints/infra/logging/Simber.kt	Made Throwable parameter non-optional and simplified internal logic to handle only non-null cases
infra/logging/src/test/java/com/simprints/infra/logging/writers/CrashlyticsLogWriterTest.kt	Removed test for deprecated null-Throwable behavior
infra/ui-base/src/main/java/com/simprints/infra/uibase/navigation/NavigationResultExt.kt	Added IllegalStateException for navigation failure warning
infra/matching/src/main/java/com/simprints/infra/matching/usecase/FingerprintMatcherUseCase.kt	Added IllegalArgumentException for missing SDK warning
infra/matching/src/main/java/com/simprints/infra/matching/usecase/FaceMatcherUseCase.kt	Added IllegalArgumentException for missing SDK warning
infra/event-sync/src/main/java/com/simprints/infra/eventsync/event/commcare/CommCareEventDataSource.kt	Added IllegalArgumentException for date parsing failure warning
feature/orchestrator/src/main/java/com/simprints/feature/orchestrator/usecases/steps/FallbackToCommCareDataSourceIfNeededUseCase.kt	Added Exception for CommCare fallback scenario warning
infra/event-sync/src/test/java/com/simprints/infra/eventsync/event/commcare/CommCareEventDataSourceTest.kt	Updated test assertions to verify Throwable parameter is provided

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud