Remove redundant config refresh#1468
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes redundant configuration refreshes and reorganizes the RealmToRoomMigrationScheduler responsibility from ConfigManager to ProjectConfigDownSyncWorker.
Key Changes
- Moved
RealmToRoomMigrationSchedulerinvocation fromConfigManager.refreshProject()toProjectConfigDownSyncWorker - Refactored
EventUpSyncTaskto usegetProject()andgetProjectConfiguration()instead ofrefreshProject()to avoid unnecessary config refreshes - Updated execution order in
ProjectConfigDownSyncWorker: migration scheduler now runs before worker rescheduling
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| infra/config-sync/src/main/java/com/simprints/infra/config/sync/ConfigManager.kt | Removed RealmToRoomMigrationScheduler dependency and call from refreshProject() |
| infra/config-sync/src/test/java/com/simprints/infra/config/sync/ConfigManagerTest.kt | Updated test to reflect removal of migration scheduler from ConfigManager |
| infra/sync/src/main/java/com/simprints/infra/sync/config/worker/ProjectConfigDownSyncWorker.kt | Added RealmToRoomMigrationScheduler dependency and invocation, reordered operations |
| infra/sync/src/test/java/com/simprints/infra/sync/config/worker/ProjectConfigDownSyncWorkerTest.kt | Added migration scheduler mock and verification (contains order mismatch bug) |
| infra/event-sync/src/main/java/com/simprints/infra/eventsync/sync/up/tasks/EventUpSyncTask.kt | Changed from refreshProject() to getProject()/getProjectConfiguration() to avoid redundant refresh |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…okenization in ConfigManager; Move local records reset before worker rescheduling
05a9a87 to
403fbd2
Compare
|
luhmirin-s
approved these changes
Nov 19, 2025
meladRaouf
approved these changes
Nov 19, 2025
alexandr-simprints
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



JIRA ticket
Will be released in: 2026.1.0
Notable changes
Testing guidance
Additional work checklist