Skip to content

MS-1006 Minor project manager rework#1486

Merged
luhmirin-s merged 2 commits into
mainfrom
feature/MS-1006-project-manager-rework
Dec 4, 2025
Merged

MS-1006 Minor project manager rework#1486
luhmirin-s merged 2 commits into
mainfrom
feature/MS-1006-project-manager-rework

Conversation

@luhmirin-s
Copy link
Copy Markdown
Contributor

JIRA ticket
Will be released in: 2026.1.0

Root cause analysis (for bugfixes only)

First known affected version: 2025.4.0

  • Project refresh does not have any exception handling, so if there is an authentication or network error during project data refresh, it might crash the app if not handled on the caller's side.
  • There are a couple of very rare edge cases in which it was not handled and we got couple of crash reports.

Notable changes

  • Change getProject() to a nullable return in case of any exceptions.
  • Removed the project ID argument from getProject() and got the ID directly from the auth store inside the config manager. This removes the need to add the auth store dependency every time the project is required.

Testing guidance

  • Do some smoke testing - everything should function as is
  • Mark the device as "compromised" and ensure that the user is logged out without a crash.

Additional work checklist

  • Effect on other features and security has been considered
  • Design document marked as "In development" (if applicable)
  • External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
  • Test cases in Testiny are up to date (or ticket created)
  • Other teams notified about the changes (if applicable)

@luhmirin-s luhmirin-s requested review from a team, BurningAXE, TristramN, alex-vt, alexandr-simprints, meladRaouf and ybourgery and removed request for a team December 2, 2025 15:17
@cla-bot cla-bot Bot added the ... label Dec 2, 2025
@luhmirin-s luhmirin-s force-pushed the feature/MS-1006-project-manager-rework branch from cb741e9 to 4d56b2b Compare December 3, 2025 08:19
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Dec 3, 2025

@luhmirin-s luhmirin-s merged commit 2f39585 into main Dec 4, 2025
13 checks passed
@luhmirin-s luhmirin-s deleted the feature/MS-1006-project-manager-rework branch December 4, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants