Skip to content

MS-1235 Hiding Audio alert option only if fingerprint modality is configured #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luhmirin-s merged 1 commit into from
Dec 4, 2025
Merged

MS-1235 Hiding Audio alert option only if fingerprint modality is configured #1489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions feature/dashboard/src/main/java/com/simprints/feature/dashboard/settings/SettingsFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ internal class SettingsFragment : PreferenceFragmentCompat() {
findNavController().popBackStack()
}
viewModel.generalConfiguration.observe(viewLifecycleOwner) {
enableFingerprintSettings(it.modalities)
enableFingerprintSettings(it.modalities.contains(Modality.FINGERPRINT))
}
viewModel.experimentalConfiguration.observe(viewLifecycleOwner) {
showFaceAutoCaptureSetting(isVisible = it.faceAutoCaptureEnabled)
Expand Down Expand Up @@ -91,8 +91,9 @@ internal class SettingsFragment : PreferenceFragmentCompat() {
bindClickListeners()
}

private fun enableFingerprintSettings(modalities: List<Modality>) {
getFingerSelectionPreference()?.isVisible = modalities.contains(Modality.FINGERPRINT)
private fun enableFingerprintSettings(enabled: Boolean) {
getFingerSelectionPreference()?.isVisible = enabled
getAudioAlertPreference()?.isVisible = enabled
}

private fun bindClickListeners() {
Expand Down Expand Up @@ -215,6 +216,8 @@ internal class SettingsFragment : PreferenceFragmentCompat() {

private fun getAboutPreference(): Preference? = findPreference(getString(R.string.preference_app_details_key))

private fun getAudioAlertPreference(): Preference? = findPreference(getString(R.string.preference_enable_audio_on_scan_complete_key))

private fun getFaceAutoCapturePreference(): Preference? = findPreference(getString(R.string.preference_enable_face_auto_capture))

private fun showFaceAutoCaptureSetting(isVisible: Boolean) {
Expand Down