[MS-1271] Identification results now always return the MF-ID credential matches first, ignoring the confidence threshold

[alexandr-simprints]

JIRA ticket
Will be released in: 2025.4.0

Root cause analysis (for bugfixes only)

First known affected version: 2025.4.0

When running a 1:N identification in the scenario where:

• We do a 1:N
• We don't have a biometric match
• We do have an NHIS match

SID fails to return the NHIS-linked GUID. Instead, the result set is empty. This is because the credential results were filtered out by the threshold. We need to always include the GUIDs linked to credential regardless of the matching score.

Notable changes

• GUIDs linked to credential are now at the top of the returned Identification list, regardless of their matching score
• 1:N biometric matches are returned as usual, no changes there

Testing guidance

• Enrol subject A and B with different biometrics, and different credentials.
• Start identification, and capture the biometrics of the subject A, and credentials of the subject B
• Observe, that both subjects are returned in the respons

Additional work checklist

• Effect on other features and security has been considered
• Design document marked as "In development" (if applicable)
• External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
• Test cases in Testiny are up to date (or ticket created) TC-312
• Other teams notified about the changes (if applicable)

[Copilot]

Pull request overview

This PR fixes a bug (MS-1271) where credential matches (e.g., NHIS/MF-ID matches) were incorrectly filtered out by the confidence threshold during 1:N identification. The fix ensures that credential-linked GUIDs are always returned at the top of the identification results list, regardless of their matching score.

Key Changes

• Credential matches now bypass confidence threshold filtering and are always included in results
• Credential results are returned before biometric (1:N) match results
• Removed unused projectConfiguration parameter from mapToMatchResults function

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
feature/orchestrator/src/main/java/com/simprints/feature/orchestrator/usecases/response/CreateIdentifyResponseUseCase.kt	Modified identification response logic to always return credential matches regardless of confidence score, and restructured to place credential results before biometric matches
feature/orchestrator/src/test/java/com/simprints/feature/orchestrator/usecases/response/CreateIdentifyResponseUseCaseTest.kt	Consolidated and updated tests for credential matching behavior, including testing combined face and fingerprint credential results

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud