MS-1257 Terminology fix (the easy parts)#1506
Merged
Merged
Conversation
3969486 to
07e393c
Compare
alexandr-simprints
approved these changes
Dec 16, 2025
alex-vt
approved these changes
Dec 16, 2025
There was a problem hiding this comment.
Pull request overview
This PR implements terminology fixes for biometric data structures, renaming classes and reorganizing template-related data to improve clarity and consistency across the codebase. The changes focus on temporary models used in capture results and how biometric templates are stored.
Key Changes:
- Renamed
SampleIdentifiertoTemplateIdentifierand moved to the reference package - Introduced
BiometricTemplatedata class to encapsulate template data and identifier - Renamed capture-related classes:
CaptureSample→BiometricTemplateCapture,CaptureIdentity→BiometricReferenceCapture - Renamed
MatchComparisonResult→ComparisonResultwithconfidencefield renamed tocomparisonScore
Reviewed changes
Copilot reviewed 152 out of 152 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
infra/core/src/main/java/com/simprints/core/domain/reference/ |
New package containing renamed and restructured biometric reference classes |
infra/core/src/main/java/com/simprints/core/domain/sample/ |
Updated Sample class to use BiometricTemplate; removed old classes |
infra/matching/src/main/java/ |
Updated matching infrastructure to use new terminology throughout |
fingerprint/infra/*/src/main/java/ |
Updated fingerprint SDK implementations to work with BiometricReferenceCapture |
feature/orchestrator/src/main/java/ |
Updated orchestrator to handle new biometric reference structures |
| Test files across modules | Updated tests to reflect new class names and structure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
meladRaouf
approved these changes
Dec 16, 2025
…dentity to BiometricReferenceCapture
…ular template class
ed60b72 to
eaab2b9
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



JIRA ticket
To keep everyone's sanity, I have decided to split the terminology fix into smaller parts. This first PR is just the data classes that are not persisted anywhere. This mostly relates to the temporary models in capture results and how the biometric template is stored.
Notable changes
SampleIdentifier->TemplateIdentifierBiometricTemplateCaptureSample->BiometricTemplateCaptureCaptureIdentity->BiometricReferenceCaptureMatchComparisonResult->ComparisonResultTesting guidance
Additional work checklist