Skip to content

MS-1257 Terminology fix (the easy parts)#1506

Merged
luhmirin-s merged 5 commits into
mainfrom
feature/MS-1257-terminology-fix
Dec 17, 2025
Merged

MS-1257 Terminology fix (the easy parts)#1506
luhmirin-s merged 5 commits into
mainfrom
feature/MS-1257-terminology-fix

Conversation

@luhmirin-s
Copy link
Copy Markdown
Contributor

JIRA ticket

To keep everyone's sanity, I have decided to split the terminology fix into smaller parts. This first PR is just the data classes that are not persisted anywhere. This mostly relates to the temporary models in capture results and how the biometric template is stored.

Notable changes

  • SampleIdentifier -> TemplateIdentifier
  • Moved template array and the identifier into the dedicated data class BiometricTemplate
  • CaptureSample -> BiometricTemplateCapture
  • CaptureIdentity -> BiometricReferenceCapture
  • MatchComparisonResult -> ComparisonResult

Testing guidance

  • App should work exactly as before during all of the regular regression tests.

Additional work checklist

  • Effect on other features and security has been considered
  • Design document marked as "In development" (if applicable)
  • External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
  • Test cases in Testiny are up to date (or ticket created)
  • Other teams notified about the changes (if applicable)

@luhmirin-s luhmirin-s requested review from a team, BurningAXE, TristramN, alex-vt, alexandr-simprints, meladRaouf and ybourgery and removed request for a team December 15, 2025 08:39
@cla-bot cla-bot Bot added the ... label Dec 15, 2025
@luhmirin-s luhmirin-s force-pushed the feature/MS-1257-terminology-fix branch from 3969486 to 07e393c Compare December 15, 2025 10:52
@BurningAXE BurningAXE requested a review from Copilot December 16, 2025 17:21
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements terminology fixes for biometric data structures, renaming classes and reorganizing template-related data to improve clarity and consistency across the codebase. The changes focus on temporary models used in capture results and how biometric templates are stored.

Key Changes:

  • Renamed SampleIdentifier to TemplateIdentifier and moved to the reference package
  • Introduced BiometricTemplate data class to encapsulate template data and identifier
  • Renamed capture-related classes: CaptureSampleBiometricTemplateCapture, CaptureIdentityBiometricReferenceCapture
  • Renamed MatchComparisonResultComparisonResult with confidence field renamed to comparisonScore

Reviewed changes

Copilot reviewed 152 out of 152 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
infra/core/src/main/java/com/simprints/core/domain/reference/ New package containing renamed and restructured biometric reference classes
infra/core/src/main/java/com/simprints/core/domain/sample/ Updated Sample class to use BiometricTemplate; removed old classes
infra/matching/src/main/java/ Updated matching infrastructure to use new terminology throughout
fingerprint/infra/*/src/main/java/ Updated fingerprint SDK implementations to work with BiometricReferenceCapture
feature/orchestrator/src/main/java/ Updated orchestrator to handle new biometric reference structures
Test files across modules Updated tests to reflect new class names and structure

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@luhmirin-s luhmirin-s force-pushed the feature/MS-1257-terminology-fix branch from ed60b72 to eaab2b9 Compare December 17, 2025 08:17
@sonarqubecloud
Copy link
Copy Markdown

@luhmirin-s luhmirin-s merged commit e3a897f into main Dec 17, 2025
13 checks passed
@luhmirin-s luhmirin-s deleted the feature/MS-1257-terminology-fix branch December 17, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants