Skip to content

Fix new enrolment check in cases when match result is empty #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luhmirin-s merged 1 commit into from
Dec 22, 2025
Merged

Fix new enrolment check in cases when match result is empty #1517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...c/main/java/com/simprints/feature/orchestrator/usecases/response/IsNewEnrolmentUseCase.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@ internal class IsNewEnrolmentUseCase @Inject constructor() {
private fun isResultBelowMediumThreshold(
projectConfiguration: ProjectConfiguration,
matchResult: MatchResult,
): Boolean = projectConfiguration
): Boolean = matchResult.results.isEmpty() || projectConfiguration
.getModalitySdkConfig(matchResult.sdk)
?.decisionPolicy
?.medium
?.toFloat()
?.let { threshold -> matchResult.results.isNotEmpty() && matchResult.results.all { it.comparisonScore < threshold } } != false
?.let { threshold -> matchResult.results.all { it.comparisonScore < threshold } } != false
}
17 changes: 17 additions & 0 deletions ...st/java/com/simprints/feature/orchestrator/usecases/response/IsNewEnrolmentUseCaseTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,23 @@ internal class IsNewEnrolmentUseCaseTest {
assertThat(useCase(projectConfiguration, listOf())).isTrue()
}

@Test
fun `Results are new enrolment if all match result is empty`() {
every { projectConfiguration.general.duplicateBiometricEnrolmentCheck } returns true

assertThat(
useCase(
projectConfiguration,
listOf(
MatchResult(
listOf(),
FingerprintConfiguration.BioSdk.SECUGEN_SIM_MATCHER,
),
),
),
).isTrue()
}

@Test
fun `Results are new enrolment if fingerprint match results are of lower then medium confidence`() {
every { projectConfiguration.general.duplicateBiometricEnrolmentCheck } returns true
Expand Down