Skip to content

MS-448 ConfigManager removal#1521

Merged
luhmirin-s merged 3 commits into
mainfrom
feature/MS-448-config-manager-removal
Jan 8, 2026
Merged

MS-448 ConfigManager removal#1521
luhmirin-s merged 3 commits into
mainfrom
feature/MS-448-config-manager-removal

Conversation

@luhmirin-s
Copy link
Copy Markdown
Contributor

JIRA ticket
Will be released in: 2026.1.0

Notable changes

  • Replaced usages of ConfigManager with direct calls to ConfigRepository.
  • Deleted infra:config-sync module.
  • Most of the line changes are plain rename/replace and copy-paste of a tiny amount of business logic from config-sync to config-store.

Testing guidance

  • Everything should be working as before.

Additional work checklist

  • Effect on other features and security has been considered
  • Design document marked as "In development" (if applicable)
  • External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
  • Test cases in Testiny are up to date (or ticket created)
  • Other teams notified about the changes (if applicable)

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes the ConfigManager wrapper class and replaces all usages with direct calls to ConfigRepository. The main changes involve:

  • Deleting the infra:config-sync module entirely
  • Moving business logic from ConfigManager to ConfigRepository
  • Updating all references throughout the codebase from ConfigManager to ConfigRepository

Reviewed changes

Copilot reviewed 172 out of 172 changed files in this pull request and generated no comments.

Show a summary per file
File Description
settings.gradle.kts Removes the :infra:config-sync module from the project
infra/config-store/src/main/java/com/simprints/infra/config/store/ConfigRepository.kt Adds observeIsProjectRefreshing() method and changes getProject() return type to nullable
infra/config-store/src/main/java/com/simprints/infra/config/store/ConfigRepositoryImpl.kt Moves business logic from ConfigManager including refresh state tracking and auto-fetch behavior
infra/config-store/src/main/java/com/simprints/infra/config/store/ConfigSyncCache.kt Moves from config-sync package to config-store package
Multiple build.gradle.kts files Removes dependency on :infra:config-sync module
Multiple source and test files Replaces ConfigManager references with ConfigRepository
testing/data-generator/.../InsertEnrollmentRecordsUseCase.kt Adds null check for getProject() return value
infra/enrolment-records/.../RealmToRoomMigrationWorker.kt Adds null check for getProject() return value
infra/event-sync/.../EventSyncManagerImpl.kt Adds null checks and uses extracted project variable
infra/event-sync/.../BaseEventDownSyncDownloaderWorker.kt Adds null check with early return when project is missing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@luhmirin-s luhmirin-s force-pushed the feature/MS-448-tokenisation-improvements branch from bf1afa9 to d2cd3e7 Compare January 7, 2026 15:53
@luhmirin-s luhmirin-s force-pushed the feature/MS-448-config-manager-removal branch from 4fe4382 to 3db1cfb Compare January 7, 2026 15:53
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jan 7, 2026

@BurningAXE
Copy link
Copy Markdown
Contributor

🎉

Base automatically changed from feature/MS-448-tokenisation-improvements to main January 8, 2026 15:09
@luhmirin-s luhmirin-s merged commit 26dbbbc into main Jan 8, 2026
13 checks passed
@luhmirin-s luhmirin-s deleted the feature/MS-448-config-manager-removal branch January 8, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants