MS-448 ConfigManager removal#1521
Merged
Merged
Conversation
5 tasks
There was a problem hiding this comment.
Pull request overview
This pull request removes the ConfigManager wrapper class and replaces all usages with direct calls to ConfigRepository. The main changes involve:
- Deleting the
infra:config-syncmodule entirely - Moving business logic from
ConfigManagertoConfigRepository - Updating all references throughout the codebase from
ConfigManagertoConfigRepository
Reviewed changes
Copilot reviewed 172 out of 172 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| settings.gradle.kts | Removes the :infra:config-sync module from the project |
| infra/config-store/src/main/java/com/simprints/infra/config/store/ConfigRepository.kt | Adds observeIsProjectRefreshing() method and changes getProject() return type to nullable |
| infra/config-store/src/main/java/com/simprints/infra/config/store/ConfigRepositoryImpl.kt | Moves business logic from ConfigManager including refresh state tracking and auto-fetch behavior |
| infra/config-store/src/main/java/com/simprints/infra/config/store/ConfigSyncCache.kt | Moves from config-sync package to config-store package |
| Multiple build.gradle.kts files | Removes dependency on :infra:config-sync module |
| Multiple source and test files | Replaces ConfigManager references with ConfigRepository |
| testing/data-generator/.../InsertEnrollmentRecordsUseCase.kt | Adds null check for getProject() return value |
| infra/enrolment-records/.../RealmToRoomMigrationWorker.kt | Adds null check for getProject() return value |
| infra/event-sync/.../EventSyncManagerImpl.kt | Adds null checks and uses extracted project variable |
| infra/event-sync/.../BaseEventDownSyncDownloaderWorker.kt | Adds null check with early return when project is missing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bf1afa9 to
d2cd3e7
Compare
4fe4382 to
3db1cfb
Compare
|
BurningAXE
approved these changes
Jan 8, 2026
Contributor
|
🎉 |
Base automatically changed from
feature/MS-448-tokenisation-improvements
to
main
January 8, 2026 15:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



JIRA ticket
Will be released in: 2026.1.0
Notable changes
ConfigManagerwith direct calls toConfigRepository.infra:config-syncmodule.config-synctoconfig-store.Testing guidance
Additional work checklist