[MS-1292] Refactor feature/login to use Kotlin Serialization instead of Jackson

[meladRaouf]

JIRA ticket
Will be released in: 2026.1.0

Notable changes

• Refactor feature/login to use Kotlin Serialization instead of Jackson to parse the qr code results json

Testing guidance

• Login in SID using qrcode scanner to scan the project id and secret

Additional work checklist

• Effect on other features and security has been considered
• Design document marked as "In development" (if applicable)
• External (Gitbook) and internal (Confluence) Documentation is up-to-date (or ticket created)
• Test cases in Testiny are up to date (or ticket created)
• Other teams notified about the changes (if applicable)

[Copilot]

Pull request overview

This PR refactors the feature/login module to use Kotlin Serialization instead of Jackson for parsing QR code JSON results. This is part of a broader migration effort to standardize on Kotlin Serialization across the codebase.

Changes:

• Replaced Jackson annotations with Kotlin Serialization annotations in QrCodeContent data class
• Updated LoginFormViewModel to use JsonHelper.json.decodeFromString() instead of JsonHelper.fromJson()
• Removed Jackson dependencies from build.gradle.kts files
• Updated tests to use actual JSON strings instead of mocking the JSON parsing

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
infra/ui-base/build.gradle.kts	Removed Jackson dependency from ui-base module
feature/login/build.gradle.kts	Removed Jackson dependency and added Kotlin Serialization plugin
feature/login/src/main/java/com/simprints/feature/login/screens/qrscanner/QrCodeContent.kt	Replaced Jackson @JsonProperty with Kotlin Serialization @SerialName annotation and added @Serializable
feature/login/src/main/java/com/simprints/feature/login/screens/form/LoginFormViewModel.kt	Updated JSON parsing to use Kotlin Serialization API; added blank lines in when expression
feature/login/src/test/java/com/simprints/feature/login/screens/form/LoginFormViewModelTest.kt	Updated tests to use actual JSON strings and removed JsonHelper mock; changed to wildcard imports

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Wildcard imports should be avoided. Instead of using import com.google.common.truth.Truth.* and import io.mockk.*, explicitly import only the functions and classes that are used in this file. This makes dependencies clearer and avoids potential naming conflicts.

[luhmirin-s]

Explicitly allowed in tests.

[Copilot]

Wildcard imports should be avoided. Instead of using import io.mockk.*, explicitly import only the functions and classes that are used in this file (e.g., MockKAnnotations, clearMocks, coEvery, every, mockk, slot, verify). This makes dependencies clearer and avoids potential naming conflicts.

Suggested change

	import io.mockk.*
	import io.mockk.MockKAnnotations
	import io.mockk.clearMocks
	import io.mockk.coEvery
	import io.mockk.every
	import io.mockk.mockk
	import io.mockk.slot
	import io.mockk.verify

[Copilot]

The blank lines between each branch of the when expression are unnecessary and inconsistent with typical Kotlin style conventions. Consider removing these extra blank lines to make the code more compact and readable.

Suggested change

	AuthenticateDataResult.BadCredentials -> SignInState.BadCredentials
	AuthenticateDataResult.IntegrityException -> SignInState.IntegrityException
	AuthenticateDataResult.IntegrityServiceTemporaryDown -> SignInState.IntegrityServiceTemporaryDown
	AuthenticateDataResult.MissingOrOutdatedGooglePlayStoreApp -> SignInState.MissingOrOutdatedGooglePlayStoreApp
	AuthenticateDataResult.Offline -> SignInState.Offline
	AuthenticateDataResult.TechnicalFailure -> SignInState.TechnicalFailure
	AuthenticateDataResult.Unknown -> SignInState.Unknown
	AuthenticateDataResult.BadCredentials -> SignInState.BadCredentials
	AuthenticateDataResult.IntegrityException -> SignInState.IntegrityException
	AuthenticateDataResult.IntegrityServiceTemporaryDown -> SignInState.IntegrityServiceTemporaryDown
	AuthenticateDataResult.MissingOrOutdatedGooglePlayStoreApp -> SignInState.MissingOrOutdatedGooglePlayStoreApp
	AuthenticateDataResult.Offline -> SignInState.Offline
	AuthenticateDataResult.TechnicalFailure -> SignInState.TechnicalFailure
	AuthenticateDataResult.Unknown -> SignInState.Unknown

[luhmirin-s]

I will look into disabling those rules.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud