[MS-1293] Refactor feature/clientapi to use Kotlin Serialization instead of Jackson#1527
Merged
Conversation
535f3b7 to
7da610e
Compare
There was a problem hiding this comment.
Pull request overview
This PR refactors the feature/client-api module to use Kotlin Serialization instead of Jackson for JSON processing, as part of a broader effort to migrate away from Jackson throughout the codebase before the 2026.1.0 release.
Changes:
- Replaced Jackson JSON processing with Kotlin Serialization in the client-api feature module
- Updated
validateJsonOrThrowto use Kotlin Serialization'sparseToJsonElement - Removed Jackson-specific serialization module setup for
TokenizableString(now handled by@Serializableannotations)
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
infra/core/src/main/java/com/simprints/core/tools/json/JsonHelper.kt |
Updated validateJsonOrThrow to use Kotlin Serialization instead of Jackson's readTree, with appropriate documentation |
feature/client-api/src/main/java/com/simprints/feature/clientapi/usecases/GetEnrolmentCreationEventForRecordUseCase.kt |
Removed Jackson imports and custom serialization module; replaced toJson call with json.encodeToString |
feature/client-api/src/main/java/com/simprints/feature/clientapi/mappers/request/extractors/ActionRequestExtractor.kt |
Refactored getSubjectAge() to use Kotlin Serialization for parsing metadata JSON; removed unused Intent extension |
feature/client-api/src/test/java/com/simprints/feature/clientapi/usecases/GetEnrolmentCreationEventForRecordUseCaseTest.kt |
Updated test to verify the new encodeToString method call instead of toJson |
feature/client-api/src/test/java/com/simprints/feature/clientapi/mappers/request/extractors/ActionRequestExtractorTest.kt |
Added comprehensive test coverage for getSubjectAge() with edge cases |
feature/client-api/build.gradle.kts |
Added Kotlin Serialization plugin and removed Jackson dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
BurningAXE
approved these changes
Jan 12, 2026
luhmirin-s
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



JIRA ticket
Will be released in: 2026.1.0
Notable changes
Testing guidance
Additional work checklist