-
Notifications
You must be signed in to change notification settings - Fork 2
[MS-1284] Refactor config store models to use Kotlin Serialization #1529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,7 +16,7 @@ internal class SimpleEventReporter @Inject constructor( | |
| ) { | ||
| fun addInvalidIntentEvent( | ||
| action: String, | ||
| extras: Map<String, Any>, | ||
| extras: Map<String, String>, | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am still verifying this part, as I believe using
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Tested and it is working as expected. below an example event
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think that this might only be used in the dashboard reporting and values are only looked at in case of deep investigation, so just strings would be fine.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What happens if other types are passed?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, you are explicitly converting it. Then I guess it's fine. |
||
| ) { | ||
| sessionCoroutineScope.launch { | ||
| coreEventRepository.addOrUpdateEvent(InvalidIntentEvent(timeHelper.now(), action, extras)) | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.