[MS-1290] Each credential match now produces a OneToOne event#1532
Merged
alexandr-simprints merged 2 commits intoJan 14, 2026
Conversation
alexandr-simprints
requested review from
BurningAXE,
alex-vt,
luhmirin-s and
meladRaouf
luhmirin-s
approved these changes
Jan 14, 2026
ybourgery
reviewed
Jan 14, 2026
ybourgery
reviewed
Jan 14, 2026
ybourgery
reviewed
Jan 14, 2026
ybourgery
requested changes
Jan 14, 2026
Collaborator
ybourgery
left a comment
ybourgery
left a comment
There was a problem hiding this comment.
I think the timestamp are not the most accurate to represent what is actually happening
…hCandidatesUseCase to properly reflect the start and end time
| MatchEntry(subjectId, confidence) | ||
| }, | ||
| fingerComparisonStrategy = if (match.isFaceMatch) null else getFingerprintComparisonStrategy(match.fingerprintBioSdk!!), | ||
| probeBiometricReferenceId = match.probeReferenceId.orEmpty(), |
There was a problem hiding this comment.
Using orEmpty() on probeReferenceId silently converts null to an empty string. Consider whether an empty string is semantically correct for this field, or if null should be preserved or handled differently. If an empty string is intentional when the value is absent, this is acceptable.
Suggested change
| probeBiometricReferenceId = match.probeReferenceId.orEmpty(), | |
| probeBiometricReferenceId = match.probeReferenceId, |
BurningAXE
approved these changes
Jan 14, 2026
|
ybourgery
approved these changes
Jan 14, 2026
alexandr-simprints
deleted the
MS-1290-mfid-matching-with-existing-credential-does-not-create-match-events
branch
luhmirin-s
pushed a commit
that referenced
this pull request
Jan 19, 2026
* [MS-1290] Each credential match now produces a OneToOne event * [MS-1290] Moving the OneToOne match events from ViewModel to the MatchCandidatesUseCase to properly reflect the start and end time # Conflicts: # feature/external-credential/src/main/java/com/simprints/feature/externalcredential/model/CredentialMatch.kt # feature/external-credential/src/main/java/com/simprints/feature/externalcredential/screens/search/ExternalCredentialSearchViewModel.kt # feature/external-credential/src/main/java/com/simprints/feature/externalcredential/screens/search/usecase/MatchCandidatesUseCase.kt # feature/external-credential/src/main/java/com/simprints/feature/externalcredential/usecase/ExternalCredentialEventTrackerUseCase.kt # feature/external-credential/src/test/java/com/simprints/feature/externalcredential/screens/search/usecase/MatchCandidatesUseCaseTest.kt # feature/external-credential/src/test/java/com/simprints/feature/externalcredential/usecase/ExternalCredentialEventTrackerUseCaseTest.kt # feature/orchestrator/src/test/java/com/simprints/feature/orchestrator/cache/OrchestratorCacheIntegrationTest.kt
luhmirin-s
pushed a commit
that referenced
this pull request
Jan 20, 2026
* [MS-1290] Each credential match now produces a OneToOne event * [MS-1290] Moving the OneToOne match events from ViewModel to the MatchCandidatesUseCase to properly reflect the start and end time # Conflicts: # feature/external-credential/src/main/java/com/simprints/feature/externalcredential/model/CredentialMatch.kt # feature/external-credential/src/main/java/com/simprints/feature/externalcredential/screens/search/ExternalCredentialSearchViewModel.kt # feature/external-credential/src/main/java/com/simprints/feature/externalcredential/screens/search/usecase/MatchCandidatesUseCase.kt # feature/external-credential/src/main/java/com/simprints/feature/externalcredential/usecase/ExternalCredentialEventTrackerUseCase.kt # feature/external-credential/src/test/java/com/simprints/feature/externalcredential/screens/search/usecase/MatchCandidatesUseCaseTest.kt # feature/external-credential/src/test/java/com/simprints/feature/externalcredential/usecase/ExternalCredentialEventTrackerUseCaseTest.kt # feature/orchestrator/src/test/java/com/simprints/feature/orchestrator/cache/OrchestratorCacheIntegrationTest.kt
luhmirin-s
pushed a commit
that referenced
this pull request
Jan 20, 2026
* [MS-1290] Each credential match now produces a OneToOne event * [MS-1290] Moving the OneToOne match events from ViewModel to the MatchCandidatesUseCase to properly reflect the start and end time # Conflicts: # feature/external-credential/src/main/java/com/simprints/feature/externalcredential/model/CredentialMatch.kt # feature/external-credential/src/main/java/com/simprints/feature/externalcredential/screens/search/ExternalCredentialSearchViewModel.kt # feature/external-credential/src/main/java/com/simprints/feature/externalcredential/screens/search/usecase/MatchCandidatesUseCase.kt # feature/external-credential/src/main/java/com/simprints/feature/externalcredential/usecase/ExternalCredentialEventTrackerUseCase.kt # feature/external-credential/src/test/java/com/simprints/feature/externalcredential/screens/search/usecase/MatchCandidatesUseCaseTest.kt # feature/external-credential/src/test/java/com/simprints/feature/externalcredential/usecase/ExternalCredentialEventTrackerUseCaseTest.kt # feature/orchestrator/src/test/java/com/simprints/feature/orchestrator/cache/OrchestratorCacheIntegrationTest.kt
luhmirin-s
pushed a commit
that referenced
this pull request
Jan 20, 2026
* [MS-1290] Each credential match now produces a OneToOne event * [MS-1290] Moving the OneToOne match events from ViewModel to the MatchCandidatesUseCase to properly reflect the start and end time # Conflicts: # feature/external-credential/src/main/java/com/simprints/feature/externalcredential/model/CredentialMatch.kt # feature/external-credential/src/main/java/com/simprints/feature/externalcredential/screens/search/ExternalCredentialSearchViewModel.kt # feature/external-credential/src/main/java/com/simprints/feature/externalcredential/screens/search/usecase/MatchCandidatesUseCase.kt # feature/external-credential/src/main/java/com/simprints/feature/externalcredential/usecase/ExternalCredentialEventTrackerUseCase.kt # feature/external-credential/src/test/java/com/simprints/feature/externalcredential/screens/search/usecase/MatchCandidatesUseCaseTest.kt # feature/external-credential/src/test/java/com/simprints/feature/externalcredential/usecase/ExternalCredentialEventTrackerUseCaseTest.kt # feature/orchestrator/src/test/java/com/simprints/feature/orchestrator/cache/OrchestratorCacheIntegrationTest.kt
luhmirin-s
pushed a commit
that referenced
this pull request
Jan 21, 2026
* [MS-1290] Each credential match now produces a OneToOne event * [MS-1290] Moving the OneToOne match events from ViewModel to the MatchCandidatesUseCase to properly reflect the start and end time # Conflicts: # feature/external-credential/src/main/java/com/simprints/feature/externalcredential/model/CredentialMatch.kt # feature/external-credential/src/main/java/com/simprints/feature/externalcredential/screens/search/ExternalCredentialSearchViewModel.kt # feature/external-credential/src/main/java/com/simprints/feature/externalcredential/screens/search/usecase/MatchCandidatesUseCase.kt # feature/external-credential/src/main/java/com/simprints/feature/externalcredential/usecase/ExternalCredentialEventTrackerUseCase.kt # feature/external-credential/src/test/java/com/simprints/feature/externalcredential/screens/search/usecase/MatchCandidatesUseCaseTest.kt # feature/external-credential/src/test/java/com/simprints/feature/externalcredential/usecase/ExternalCredentialEventTrackerUseCaseTest.kt # feature/orchestrator/src/test/java/com/simprints/feature/orchestrator/cache/OrchestratorCacheIntegrationTest.kt
luhmirin-s
pushed a commit
that referenced
this pull request
Jan 21, 2026
* [MS-1290] Each credential match now produces a OneToOne event * [MS-1290] Moving the OneToOne match events from ViewModel to the MatchCandidatesUseCase to properly reflect the start and end time # Conflicts: # feature/external-credential/src/main/java/com/simprints/feature/externalcredential/model/CredentialMatch.kt # feature/external-credential/src/main/java/com/simprints/feature/externalcredential/screens/search/ExternalCredentialSearchViewModel.kt # feature/external-credential/src/main/java/com/simprints/feature/externalcredential/screens/search/usecase/MatchCandidatesUseCase.kt # feature/external-credential/src/main/java/com/simprints/feature/externalcredential/usecase/ExternalCredentialEventTrackerUseCase.kt # feature/external-credential/src/test/java/com/simprints/feature/externalcredential/screens/search/usecase/MatchCandidatesUseCaseTest.kt # feature/external-credential/src/test/java/com/simprints/feature/externalcredential/usecase/ExternalCredentialEventTrackerUseCaseTest.kt # feature/orchestrator/src/test/java/com/simprints/feature/orchestrator/cache/OrchestratorCacheIntegrationTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket
Will be released in: 2025.4.0
Root cause analysis (for bugfixes only)
First known affected version: 2025.4.0
There were no
OneToOneEventinstances for credential matches.Notable changes
Now, when a biometric probe that, linked to the credential, is being matched against a biometric probe taken during the workflow, a
OneToOnematch event is saved.Testing guidance
Awith a credentialCB, and use the same credentialCAdditional work checklist