Consolidate all event classes into a single package by eliminating sub-packages.#1534
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR consolidates all event classes from sub-packages (e.g., callout, callback, face, fingerprint, subject, samples, upsync, downsync) into the single parent package com.simprints.infra.events.event.domain.models. Additionally, it refactors Event and EventPayload from abstract to sealed classes, improving type safety.
Changes:
- Moved all event classes from sub-packages into a single package, eliminating hierarchical package organization
- Refactored
EventandEventPayloadfrom abstract to sealed classes - Moved
BiometricDataSourcefromcalloutsub-package to root models package
Reviewed changes
Copilot reviewed 137 out of 137 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Event.kt | Changed from abstract to sealed class; made getTokenizableFields() open with default empty map; marked equals() and hashCode() as final |
| EventPayload.kt | Changed from abstract to sealed class |
| BiometricDataSource.kt | Moved from callout sub-package to models package; added trailing comma |
| Various event classes | Updated package declarations from sub-packages to root models package |
| All test and production files | Updated imports to reflect new package structure |
Comments suppressed due to low confidence (2)
infra/events/src/main/java/com/simprints/infra/events/event/domain/models/Event.kt:1
- Changing
getTokenizableFields()from abstract to open with a default empty map implementation may break existing implementations that override this method. While sealed classes ensure all implementations are known at compile-time, this changes the contract. Consider verifying all subclasses still provide meaningful implementations where needed, as some may now silently fall back to the empty map default.
infra/events/src/main/java/com/simprints/infra/events/event/domain/models/BiometricReference.kt:14 - The fully qualified references
BiometricReferenceType.Companion.FACE_REFERENCE_KEYare more verbose than necessary. Since the original code used direct imports, consider maintaining consistency by importing these constants directly instead of using fully qualified names.
luhmirin-s
approved these changes
Jan 15, 2026
BurningAXE
approved these changes
Jan 15, 2026
…RecordDeletionEvent and EnrolmentRecordMoveEvent
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


JIRA ticket
Will be released in: 2026.1.0
Notable changes
EventandEventPayloadinto sealed classes.Testing guidance
Additional work checklist